Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GsfElectronBaseProducer a stream module. #4087

Merged

Conversation

Dr15Jones
Copy link
Contributor

Static analyzer and helgrind show it is safe to convert this class
and all classes inheriting from it to be a stream based Producer.
Thread performance analysis showed this conversion is needed for
efficient threading.

Static analyzer and helgrind show it is safe to convert this class
and all classes inheriting from it to be a stream based Producer.
Thread performance analysis showed this conversion is needed for
efficient threading.
@Dr15Jones
Copy link
Contributor Author

This change is purely technical and has no effect on single threaded running.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Make GsfElectronBaseProducer a stream module.

It involves the following packages:

RecoEgamma/EgammaElectronProducers

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2014

+1

for #4087 ace551a
jenkins ok, reco sig could've been bypassed

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Jun 3, 2014
…reamModule

Make GsfElectronBaseProducer a stream module.
@ktf ktf merged commit 0e24e1c into cms-sw:CMSSW_7_1_X Jun 3, 2014
@Dr15Jones Dr15Jones deleted the makeGsfElectronBaseProducerStreamModule branch June 12, 2014 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants