[13.0.X] Disentangle TrackerTrackHitFilter from phase-0 Strip conditions and activate common alignment track refitter sequence for phase-2

[mmusich]

backport of #40835

PR description:

The common alignment track selection and refitting sequence currently cannot run in Phase-2 setups because of missing Phase-0 SiStrip conditions. The module TrackerTrackHitFilter indeed requires at construction time the following conditions:

----- Begin Fatal Exception 21-Feb-2023 12:46:22 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 67 event: 6602 stream: 0
   [1] Running path 'p2'
   [2] Prefetching for module TrackerTrackHitFilter/'TrackerTrackHitFilter'
   [3] Prefetching for EventSetup module SiStripQualityESProducer/'siStripQualityESProducer'
   [4] Calling method for EventSetup module SiStripConnectivity/'sistripconn'
   [5] While getting dependent Record from Record SiStripDetCablingRcd
Exception Message:
No "SiStripFedCablingRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

As it seems that adding Phase-0 SiStrip conditions (either in GT or by dedicated ESSource) would be a wrong design choice, the goal of this PR is allow TrackerTrackHitFilter to run without Phase-0 SiStrip conditions, by means of adding a new parameter isPhase2 that governs if the SiStripClusterInfo object used in TrackerTrackHitFilter should be constructed or not with an esConsumes call.
This is achieved by using std::optional to declare the SiStripClusterInfo data member and construct it only if the workflow is not meant for Phase-2.

PR validation:

Run the dedicated test: cmsRun $CMSSW_BASE/src/Alignment/OfflineValidation/test/test_all_Phase2_cfg.py

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #40835 to be able to be used in the phase-2 alignment studies happening in that cycle (see PdmV JIRA ticket)

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_0_X.

It involves the following packages:

• Alignment/OfflineValidation (alca)
• RecoTracker/FinalTrackSelectors (reconstruction)

@malbouis, @yuanchao, @ChrisMisan, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@VourMa, @adewit, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @missirol, @rovere, @tlampen, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Disentangle TrackerTrackHitFilter from phase-0 Strip conditions and activate common alignment track refitter sequence for phase-2 #40835

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88e302/30955/summary.html
COMMIT: 598925c
CMSSW: CMSSW_13_0_X_2023-02-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40896/30955/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 7 lines from the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3557190
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3557156
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[mandrenguyen]

+reconstruction
No changes to reco comparisons, changes only affect alignment workflows

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1