Convert EcalSelectiveReadoutProducer to stream module #41712
Conversation
The static member functions were moved to a separate namespace. This avoids having other code include/link the module.
|
@makortel FYI |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41712/35592
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7013e5/32700/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
| const EcalTPGPhysicsConst* tp = hTp.product(); | ||
| const EcalTPGPhysicsConstMap& mymap = tp->getMap(); | ||
| if (mymap.size() != 2) { | ||
| cout << "Error: TPG physics record is of unexpected size: " << mymap.size() |
There was a problem hiding this comment.
@Dr15Jones , is it OK to left "cout" in this class? Does it mean that it is allowed for "one" producer? My problem with these cout - it is not obvious which class is printing and is not clear that it is ECAL. I would use logWarning in that case
.
There was a problem hiding this comment.
#41789 is created , so this PR may be merged.
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
simulation-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
The EcalSelectiveReadoutProducer was converted from a one:: to stream:: module as DIGI workflows using large numbers of threads, greater than 64, were losing efficiency because of the module. As part of the conversion, a fillDescriptions method was also added.
To avoid unnecessary coupling of two modules, the static methods in the EDAnalyzer ECalSRCondTools were removed from the module and placed in a namespace.
PR validation:
The code compiles and a simple test running the DIGI+HLT steps succeeded.