Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Number of RecHits plot for SiStrip stereo modules (backport to 13_1_X) #41753

Merged
merged 2 commits into from
May 24, 2023

Conversation

mascioti
Copy link
Contributor

PR description:

Adding Number of RecHits on Strip Stereo Modules on the Tracker DQM

PR validation:

runTheMatrix.py -l 12434

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #41725

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2023

A new Pull Request was created by @mascioti for CMSSW_13_1_X.

It involves the following packages:

  • DQM/SiStripMonitorTrack (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

backport of #41725

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0748e3/32764/summary.html
COMMIT: 40dca95
CMSSW: CMSSW_13_1_X_2023-05-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41753/32764/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222011
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221986
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 101.38000000000002 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 1.799 KiB SiStrip/IsolatedBunches
  • DQMHistoSizes: changed ( 1000.0,... ): 1.705 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 12434.0,... ): 1.729 KiB HLT/SiStrip
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@sroychow
Copy link
Contributor

@cms-sw/dqm-l2 should the tests be re-triggered?

@perrotta
Copy link
Contributor

@cms-sw/dqm-l2 should the tests be re-triggered?

@sroychow I don't see why we should. Tests are succesfull.
Moreover: since this is a verbatim backport/forwardport of the PRs already signed and merged in 13_2_X and in 13_0_X, let merge this one as such in the intermediate release 13_1_X

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5376c14 into cms-sw:CMSSW_13_1_X May 24, 2023
@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants