-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.1.X] Online DQM configure timeThreshold
appropriately when running in 'offline' mode
#41822
[13.1.X] Online DQM configure timeThreshold
appropriately when running in 'offline' mode
#41822
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_1_X. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
4c44968
to
79815fc
Compare
Pull request #41822 was updated. @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-273c55/32897/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #41816
PR description:
It was recently realized that when running the Online DQM clients in "offline" mode (e.g. in unit tests or DQM playback) the
timeThreshold
parameter of theOnlineBeamSpotESProducer
was not reset in order to account for the fact that the run played back might have been older than 48h. This PR should fix this behaviour.PR validation:
scram b runtests_TestDQMOnlineClient-beam_dqm_sourceclient use-ibeos
runs to completion.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim intermediate backport of #41816 to 13.1.X (final target 13.0.X for 2023 data-taking)