Update 13000 to 13600 in ReweightUserHooks.h for Run3

[menglu21]

PR description:

Update 13000 to 13600 in ReweightUserHooks.h for Run3

PR validation:

the plot below shows the difference between QCD samples using 13000 and 13600, the red histogram is the distribution we want.

[menglu21]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41836/35734

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @menglu21 (Meng_Lu) for master.

It involves the following packages:

• GeneratorInterface/Pythia8Interface (generators)

@SiewYan, @mkirsano, @Saptaparna, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df0aee/32920/summary.html
COMMIT: e342835
CMSSW: CMSSW_13_2_X_2023-05-31-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41836/32920/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3221457
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3221429
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[menglu21]

Hi, does anyone know what cause the error, since only one float number is modified, I think the error is not related to the modification

[perrotta]

Hi, does anyone know what cause the error, since only one float number is modified, I think the error is not related to the modification

@menglu21 There is an error in a completely unrelated unit test: I would not bother about it

[menglu21]

shall I just bypass it with "+1", this is urgent for JME

[perrotta]

shall I just bypass it with "+1", this is urgent for JME

Please do

[perrotta]

please test
(let re-run the tests anyhow)

[davidlange6]

should this 13000 -> 13600 value not be part of the module configuration to make it possible to support run 2 and run 3?

[perrotta]

should this 13000 -> 13600 value not be part of the module configuration to make it possible to support run 2 and run 3?

Good point!

[menglu21]

can we just do the modification for release used for Run3 production, i.e., master, 13_X and 12_6

[perrotta]

can we just do the modification for release used for Run3 production, i.e., master, 13_X and 12_6

Those releases will not be used ONLY for Run3 production, or at least you should not expect so

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41836/35749

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #41836 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please check and sign again.

[menglu21]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df0aee/32941/summary.html
COMMIT: 562551f
CMSSW: CMSSW_13_2_X_2023-06-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41836/32941/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 15 lines to the logs
• Reco comparison results: 55 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3221457
• DQMHistoTests: Total failures: 2231
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3219204
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[Saptaparna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[menglu21]

follow up comment since we modified the code a bit (the init plot was made by directly changing 13000 to 13600).