Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PileUpJetID] Backport of #41854 (Move average calculations outside of jet constituents loop) to 13_1_X #41869

Conversation

nurfikri89
Copy link
Contributor

Backport of #41854

####Original PR description:
This PR moves the average values calculations to outside of the jet constituents loop in PileupJetIdAlgo.cc.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_13_1_X.

It involves the following packages:

  • RecoJets/JetProducers (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @missirol, @yslai, @AnnikaStein, @jdamgov, @ahinzmann, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jun 5, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c2ea5/32979/summary.html
COMMIT: 14fd8c4
CMSSW: CMSSW_13_1_X_2023-06-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41869/32979/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221566
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Jun 6, 2023

+1

  • Master and 13_0_X indentical versions of this PR were both signed by reco and merged
  • I think that this identical PR in the intermediate 13_1_X can be also merged: please @cms-sw/reconstruction-l2 complain if I misunderstood your intentions

@mandrenguyen
Copy link
Contributor

+reconstruction
@perrotta Indeed, I think this is backport safe to all relevant releases.
I probably skipped it over b/c the "tests-rejected" flag, but it's just an input file timeout. I suppose we can safely merge it even without requiring that all tests are passed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_2_X is complete.

@perrotta
Copy link
Contributor

perrotta commented Jun 6, 2023

merge

@cmsbuild cmsbuild merged commit 9d7e691 into cms-sw:CMSSW_13_1_X Jun 6, 2023
@nurfikri89 nurfikri89 deleted the portFrom132XTo131X_puIdFix_avgOutOfLoop branch June 7, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants