Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilities/StaticAnalyzers: Remove postprocess-scan-build.py script no longer needed [13_1_X] #41904

Conversation

gartung
Copy link
Member

@gartung gartung commented Jun 8, 2023

backport of #41833
Utilities/StaticAnalyzers: Remove postprocess-scan-build.py script no longer needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2023

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_13_1_X.

It involves the following packages:

  • Utilities/StaticAnalyzers (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@gartung gartung changed the title Utilities/StaticAnalyzers: Remove postprocess-scan-build.py script no longer needed. Backport of #41833 Jun 8, 2023
@makortel
Copy link
Contributor

makortel commented Jun 8, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6d0b6/33056/summary.html
COMMIT: 5bbaeac
CMSSW: CMSSW_13_1_X_2023-06-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41904/33056/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 23 lines from the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221560
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta perrotta changed the title Backport of #41833 Utilities/StaticAnalyzers: Remove postprocess-scan-build.py script no longer needed [13_1_X] Jun 8, 2023
@makortel
Copy link
Contributor

makortel commented Jun 9, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jun 9, 2023

+1

@cmsbuild cmsbuild merged commit 5d0812e into cms-sw:CMSSW_13_1_X Jun 9, 2023
@gartung gartung deleted the gartung-SA-remove-post-process-scan-build-131x branch June 9, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants