[13_1_X] Fix a race condition in StMeasurementDetSet

[makortel]

PR description:

Backport of #41872

This PR fixes a data race in StMeasurementDetSet (concurrent writes to empty_ and ready_ are not protected, leading to undefined behavior) that was found in #41786 (comment).

PR validation:

None beyond #41872

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #41872. Fixes a data race that may be related to a crash in HLT (#41786).

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_13_1_X.

It involves the following packages:

• RecoTracker/MeasurementDet (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix a race condition in StMeasurementDetSet #41872

[makortel]

@cmsbuild, please test

[missirol]

backport of #41872

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6f920/33065/summary.html
COMMIT: 56f0b64
CMSSW: CMSSW_13_1_X_2023-06-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41909/33065/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3221591
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3221566
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[missirol]

type bugfix

@cms-sw/reconstruction-l2 , could you please sign this backport ? It's relevant to HLT (see #41786).

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1