Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.1.X] Introduce missing hits recovery in the SiStripHitEfficiency PCL and CalibTree workflows #42200

Merged
merged 4 commits into from
Jul 7, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 6, 2023

backport of #42175
backport of #41970

PR description:

These changes implement the recovery of missing hits for the mkFit trajectories. Without this, the hit efficiency is overestimated in single-sided layers.
Indico page for results : https://indico.cern.ch/event/1271487/ (Update on hit efficiency)
This PR also to extend the recovery of missing hits for the mkFit trajectories to the DQM-based SiStripHitEfficiency workflow

PR validation:

see master PR: #42175

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #42175 and #41970

DenkMybu and others added 4 commits July 5, 2023 12:21
… of mkFit trajectories

wrong deletion of line in previous commit, fixed

Added run-3 era modifier to flip parameters flag

magic numbers + logInfo + var names changes

code-format applied

changed to range-based loop

fix range-based loop on 2nd iteration

fix dereferencing iterator

code-format
@mmusich mmusich changed the title [13.1.X] Introduce missing hits recovery in the SiStripHitEfficiency PCL and CalibTree workflows [13.1.X] Introduce missing hits recovery in the SiStripHitEfficiency PCL and CalibTree workflows Jul 6, 2023
@cmsbuild cmsbuild added this to the CMSSW_13_1_X milestone Jul 6, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_1_X.

It involves the following packages:

  • CalibTracker/SiStripHitEfficiency (alca)
  • Calibration/TkAlCaRecoProducers (alca)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@echabert, @robervalwalsh, @gbenelli, @tocheng, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 6, 2023

test parameters:

  • workflow = 1001.2, 1001.3

@mmusich
Copy link
Contributor Author

mmusich commented Jul 6, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8f8a0/33570/summary.html
COMMIT: e68a53c
CMSSW: CMSSW_13_1_X_2023-07-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42200/33570/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 11 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3237726
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3237701
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 161 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jul 6, 2023

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8f8a0/33580/summary.html
COMMIT: e68a53c
CMSSW: CMSSW_13_1_X_2023-07-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42200/33580/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • Reco comparison results: 189 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3237726
  • DQMHistoTests: Total failures: 5093
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3232611
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 161 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b164476 into cms-sw:CMSSW_13_1_X Jul 7, 2023
@mmusich mmusich deleted the missingHitsRecovery_13_1_X branch July 7, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants