-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.1.X] Introduce missing hits recovery in the SiStripHitEfficiency
PCL and CalibTree
workflows
#42200
[13.1.X] Introduce missing hits recovery in the SiStripHitEfficiency
PCL and CalibTree
workflows
#42200
Conversation
… of mkFit trajectories wrong deletion of line in previous commit, fixed Added run-3 era modifier to flip parameters flag magic numbers + logInfo + var names changes code-format applied changed to range-based loop fix range-based loop on 2nd iteration fix dereferencing iterator code-format
…low to be in synch with CalibTree based one
…Harvester.cc as per code review.
SiStripHitEfficiency
PCL and CalibTree workflowsSiStripHitEfficiency
PCL and CalibTree
workflows
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_1_X. It involves the following packages:
@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild, please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8f8a0/33580/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #42175
backport of #41970
PR description:
These changes implement the recovery of missing hits for the mkFit trajectories. Without this, the hit efficiency is overestimated in single-sided layers.
Indico page for results : https://indico.cern.ch/event/1271487/ (Update on hit efficiency)
This PR also to extend the recovery of missing hits for the mkFit trajectories to the DQM-based SiStripHitEfficiency workflow
PR validation:
see master PR: #42175
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
verbatim backport of #42175 and #41970