Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hgc geometry v5 1 #4241

Merged
merged 2 commits into from
Jun 16, 2014
Merged

Conversation

vandreev11
Copy link
Contributor

@bsunanda, @pfs
new HGCAL concept geometry xml files, version 5

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vandreev11 for CMSSW_6_2_X_SLHC.

Hgc geometry v5 1

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor

lgray commented Jun 16, 2014

@vandreev11 @pfs Was this presented in a software or general meeting? Just curious to go read about it.

@pfs
Copy link
Contributor

pfs commented Jun 16, 2014

@lgray It was referred in the last software meeting and it was discussed in the general meeting. v5 is however not meant for production, it's part of the developments on-going.

@lgray
Copy link
Contributor

lgray commented Jun 16, 2014

@pfs Ah, ok. Missed the last software meeting, I'll go check it out. Thanks!

@vandreev11
Copy link
Contributor Author

@lgray, @pfs yes, it was referred in the slides on the schedule - 10 June meeting,
while for the details you may have a look into 'Update on design Geometry' 3 June meeting.

@ianna
Copy link
Contributor

ianna commented Jun 16, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @fratnikov, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

merge

Tested with 4 muons (xxx00) and single pions (xxx61). Only the expected failures, namely:

12600 crashes in step 2:

#5  0x00002afeae9ce8f1 in HcalDDDRecConstants::getHCID(int, int, int, int, int) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libGeometryHcalCommonData.so
#6  0x00002afebdb48871 in HcalHitRelabeller::relabel(unsigned int) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryHcalSimProducers.so
#7  0x00002afebdb489cf in HcalHitRelabeller::process(std::vector<PCaloHit, std::allocator<PCaloHit> >&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryHcalSimProducers.so
#8  0x00002afebdb32f29 in HcalDigitizer::accumulateCaloHits(edm::Handle<std::vector<PCaloHit, std::allocator<PCaloHit> > > const&, edm::Handle<std::vector<PCaloHit, std::allocator<PCaloHit> > > const&, int) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryHcalSimProducers.so
#9  0x00002afebdb33819 in HcalDigitizer::accumulate(edm::Event const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryHcalSimProducers.so
#10 0x00002afebdacc8bb in edm::MixingModule::accumulateEvent(edm::Event const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/pluginSimGeneralMixingModulePlugins.so

12661 crashes in step 2:

#5  0x00002b1b9bc416d3 in ShashlikGeometry::getGeometry(DetId const&) const () from /tmp/grimes/CMSSW_6_2_X_SLHC_2014-06-16-0200/lib/slc5_amd64_gcc472/libGeometryFCalGeometry.so
#6  0x00002b1ba741df35 in EcalHitResponse::timeOfFlight(DetId const&) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryEcalSimAlgos.so
#7  0x00002b1ba741e1f5 in EcalHitResponse::putAnalogSignal(PCaloHit const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryEcalSimAlgos.so
#8  0x00002b1ba741c901 in EcalTDigitizer<ESDigitizerTraits>::add(std::vector<PCaloHit, std::allocator<PCaloHit> > const&, int) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryEcalSimAlgos.so
#9  0x00002b1ba73e644a in EcalPhaseIIDigiProducer::accumulate(edm::Event const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryEcalSimProducers.so
#10 0x00002b1ba718c8bb in edm::MixingModule::accumulateEvent(edm::Event const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/pluginSimGeneralMixingModulePlugins.so

122xx, 142xx and 144xx fail in step 4:

----- Begin Fatal Exception 16-Jun-2014 16:15:20 CEST-----------------------
An exception of category 'Conditions not found' occurred while
   [0] Processing run: 1
   [1] Running path 'dqmHarvesting'
   [2] Calling beginRun for module HcalMonitorClient/'hcalClient'
Exception Message:
Unavailable HcalCalibrations for cell (HE -29,1,1)
----- End Fatal Exception -------------------------------------------------

@cmsbuild
Copy link
Contributor

Pull request #4241 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please check and sign again.

cmsbuild added a commit that referenced this pull request Jun 16, 2014
@cmsbuild cmsbuild merged commit a3dc508 into cms-sw:CMSSW_6_2_X_SLHC Jun 16, 2014
@vandreev11
Copy link
Contributor Author

Hi Mark,

asking you just to be sure,
is my commit #4605cc2 was
merged together with PR#4241?

I committed it almost at the same moment I got your message.

Thanks, cheers,
Valeri

On Jun 16, 2014, at 6:05 PM, Mark Grimes wrote:

merge

Tested with 4 muons (xxx00) and single pions (xxx61). Only the expected failures, namely:

12600 crashes in step 2:

#5 0x00002afeae9ce8f1 in HcalDDDRecConstants::getHCID(int, int, int, int, int) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libGeometryHcalCommonData.so
#6 0x00002afebdb48871 in HcalHitRelabeller::relabel(unsigned int) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryHcalSimProducers.so
#7 0x00002afebdb489cf in HcalHitRelabeller::process(std::vector<PCaloHit, std::allocator >&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryHcalSimProducers.so
#8 0x00002afebdb32f29 in HcalDigitizer::accumulateCaloHits(edm::Handle<std::vector<PCaloHit, std::allocator > > const&, edm::Handle<std::vector<PCaloHit, std::allocator > > const&, int) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryHcalSimProducers.so
#9 0x00002afebdb33819 in HcalDigitizer::accumulate(edm::Event const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryHcalSimProducers.so
#10 0x00002afebdacc8bb in edm::MixingModule::accumulateEvent(edm::Event const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/pluginSimGeneralMixingModulePlugins.so
12661 crashes in step 2:

#5 0x00002b1b9bc416d3 in ShashlikGeometry::getGeometry(DetId const&) const () from /tmp/grimes/CMSSW_6_2_X_SLHC_2014-06-16-0200/lib/slc5_amd64_gcc472/libGeometryFCalGeometry.so
#6 0x00002b1ba741df35 in EcalHitResponse::timeOfFlight(DetId const&) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryEcalSimAlgos.so
#7 0x00002b1ba741e1f5 in EcalHitResponse::putAnalogSignal(PCaloHit const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryEcalSimAlgos.so
#8 0x00002b1ba741c901 in EcalTDigitizer::add(std::vector<PCaloHit, std::allocator > const&, int) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryEcalSimAlgos.so
#9 0x00002b1ba73e644a in EcalPhaseIIDigiProducer::accumulate(edm::Event const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/libSimCalorimetryEcalSimProducers.so
#10 0x00002b1ba718c8bb in edm::MixingModule::accumulateEvent(edm::Event const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-15-0200/lib/slc5_amd64_gcc472/pluginSimGeneralMixingModulePlugins.so
122xx, 142xx and 144xx fail in step 4:

----- Begin Fatal Exception 16-Jun-2014 16:15:20 CEST-----------------------
An exception of category 'Conditions not found' occurred while
[0] Processing run: 1
[1] Running path 'dqmHarvesting'
[2] Calling beginRun for module HcalMonitorClient/'hcalClient'
Exception Message:
Unavailable HcalCalibrations for cell (HE -29,1,1)
----- End Fatal Exception -------------------------------------------------

Reply to this email directly or view it on GitHub.

@mark-grimes
Copy link

Yes, I've checked the logs and it was merged. It wasn't part of my test though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants