Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 13_1_X] Fix EmissionVetoHook for BB4L #42434

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

lauridsj
Copy link
Contributor

@lauridsj lauridsj commented Aug 1, 2023

PR description:

Backport of #42264 (fixing the Pythia FSR hook for bb4l) to CMSSW 13_1_X, as requested by @perrotta.

PR validation:

See #42264.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

See above: Backport of #42264 to CMSSW 13_1_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2023

A new Pull Request was created by @lauridsj (Laurids Jeppe) for CMSSW_13_1_X.

It involves the following packages:

  • GeneratorInterface/Pythia8Interface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

backport of #42264

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c347fd/34007/summary.html
COMMIT: abd6ebb
CMSSW: CMSSW_13_1_X_2023-07-31-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42434/34007/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3186945
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3186917
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

+1

  • Identical to the PRs already signed in the other release cycles

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

merge

@cmsbuild cmsbuild merged commit 0870b59 into cms-sw:CMSSW_13_1_X Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants