Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.2.X] Introduce PCL-like workflows for SiStrip Lorentz Angle Monitoring (and potentially calibration) #42683

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 30, 2023

backport of #42574
backport of #42680

From the original PRs:

PR description:

This PR introduces a PCL-like workflow for SiStrip Lorentz Angle Monitoring (and potentially calibration), by using the SiStripCalCosmics dataset in input. The setup closesly resemble the one presented multiple times (see e.g. this talk) in which the hall mobility of the strips modules (only TIB and TOB for the time being, grouped in regions sharing same layer / module type) is estimated by fitting the distribution of the Strip cluster multiplicity as a function of the track grazing angle.
The SiStripCalCosmics AlCaReco producer is added to the ExpressCosmics PD in autoAlCa while the new PromptCalibProdSiStripLA ALCAPrompt producer is introduced in several configuration files in Configuration/StandardSequences package.
As a minimal follow-up, in order to be able to support uploads from the Prompt Calibration Loop:

  • updated DropBoxMetaData writer and reader configuration files
  • provided steering meta-data for upload to prod / prep and for the multi-run harvesting case
  • added SiStripLorentzAngle workflow to Calibration/TkAlCaRecoProducers/test/testPCLAlCaHarvesting.py

PR validation:

Run the following command:

cmsDriver.py testReAlCa -s ALCA:PromptCalibProdSiStripLA --conditions 130X_dataRun3_Prompt_v2 --scenario cosmics --data --era Run3_2023 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 100000 --dasquery='file dataset=/Cosmics/Commissioning2023-SiStripCalCosmics-PromptReco-v1/ALCARECO run=364141' --nThreads=4 

followed by:

cmsDriver.py stepHarvest -s ALCAHARVEST:SiStripLA --conditions 130X_dataRun3_Prompt_v2 --scenario pp --data --era Run3_2023 -n -1 --filein file:PromptCalibProdSiStripLA.root

and obtained reasonable output DQM and db files.
Also run successfully the augmented relval wf 1005.0 (runTheMatrix.py -l 1005.0 -t 4 -j 8 --ibeos.

scram b runtests runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Combined backport of #42574 and #42680
While this PR is not strictly needed for the rest of the 2023 data-taking ppRef / HI runs, it would be nice to have it included in the next 13.2.X (if that's possible) in order to profit of the testing machinery setup at Tier-0, in order to ask for a dedicated replay.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 30, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X.

It involves the following packages:

  • CalibTracker/SiStripLorentzAngle (alca)
  • Calibration/TkAlCaRecoProducers (alca)
  • CondFormats/Common (db, alca)
  • Configuration/AlCa (alca)
  • Configuration/EventContent (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)

@perrotta, @rappoccio, @bbilin, @consuegs, @tvami, @cmsbuild, @AdrianoDee, @miquork, @saumyaphor4252, @antoniovilela, @srimanob, @sunilUIET, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@echabert, @VourMa, @felicepantaleo, @robervalwalsh, @argiro, @Martin-Grunewald, @thomreis, @threus, @slomeo, @makortel, @JanFSchulte, @dgulhan, @missirol, @seemasharmafnal, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @mmusich, @mtosi, @fabiocos, @rchatter, @gbenelli, @wang0jin, @sameasy this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 30, 2023

test parameters:

  • workflow = 1005.0

@mmusich
Copy link
Contributor Author

mmusich commented Aug 30, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0a09c/34541/summary.html
COMMIT: 5566c71
CMSSW: CMSSW_13_2_X_2023-08-29-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42683/34541/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3197913
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3197885
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -36749.923 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 1005.0 ): -42261.943 KiB AlCaReco/SiStrip
  • DQMHistoSizes: changed ( 1005.0 ): 5512.021 KiB AlCaReco/SiStripLorentzAngle
  • Checked 211 log files, 160 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

Copy link
Contributor

@perrotta perrotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While reviewing, a few minor (and fully innocuous) typos were spot.
They are NOT intended to be implemented in this backport, but can be taken into account for a possible follow up PR in the master

@perrotta
Copy link
Contributor

+alca

@perrotta
Copy link
Contributor

perrotta commented Aug 31, 2023

+db

@srimanob
Copy link
Contributor

+upgrade

@sunilUIET
Copy link
Contributor

+pdmv

@mmusich
Copy link
Contributor Author

mmusich commented Aug 31, 2023

They are NOT intended to be implemented in this backport, but can be taken into account for a possible follow up PR in the master

thanks @perrotta I'll take care of these later on in master.

mmusich added a commit to mmusich/cmssw that referenced this pull request Aug 31, 2023
@mmusich
Copy link
Contributor Author

mmusich commented Sep 1, 2023

@cms-sw/operations-l2 this backport is missing your signature

@mmusich
Copy link
Contributor Author

mmusich commented Sep 4, 2023

@cms-sw/orp-l2 please merge this request, this needs to be included in the next 13.2.x release for testing at Tier0

@perrotta
Copy link
Contributor

perrotta commented Sep 4, 2023

urgent

@cmsbuild cmsbuild added the urgent label Sep 4, 2023
@mmusich
Copy link
Contributor Author

mmusich commented Sep 5, 2023

@antoniovilela @rappoccio this PR is fully signed (waiting your operations signature) and despite being flagged urgent, is not yet merged. Can you clarify the foreseen integration path ?

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit c2ecea1 into cms-sw:CMSSW_13_2_X Sep 5, 2023
11 checks passed
@mmusich mmusich deleted the dev_SiStripLorentzAngleMonitor_13_2_X_backport branch September 5, 2023 08:24
cmsbuild added a commit that referenced this pull request Sep 6, 2023
…tripLA_13_3_X

miscellaneous code improvements from review of #42683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants