-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.2.X] Introduce PCL-like workflows for SiStrip Lorentz Angle Monitoring (and potentially calibration) #42683
[13.2.X] Introduce PCL-like workflows for SiStrip Lorentz Angle Monitoring (and potentially calibration) #42683
Conversation
…er and related configurations
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X. It involves the following packages:
@perrotta, @rappoccio, @bbilin, @consuegs, @tvami, @cmsbuild, @AdrianoDee, @miquork, @saumyaphor4252, @antoniovilela, @srimanob, @sunilUIET, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0a09c/34541/summary.html Comparison SummarySummary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While reviewing, a few minor (and fully innocuous) typos were spot.
They are NOT intended to be implemented in this backport, but can be taken into account for a possible follow up PR in the master
CalibTracker/SiStripLorentzAngle/interface/SiStripLorentzAngleCalibrationHelpers.h
Show resolved
Hide resolved
CalibTracker/SiStripLorentzAngle/plugins/SiStripLorentzAnglePCLHarvester.cc
Show resolved
Hide resolved
CalibTracker/SiStripLorentzAngle/plugins/SiStripLorentzAnglePCLMonitor.cc
Show resolved
Hide resolved
CalibTracker/SiStripLorentzAngle/plugins/SiStripLorentzAnglePCLMonitor.cc
Show resolved
Hide resolved
+alca
|
+db |
+upgrade |
+pdmv |
thanks @perrotta I'll take care of these later on in master. |
@cms-sw/operations-l2 this backport is missing your signature |
@cms-sw/orp-l2 please merge this request, this needs to be included in the next 13.2.x release for testing at Tier0 |
urgent |
@antoniovilela @rappoccio this PR is fully signed (waiting your |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will be automatically merged. |
…tripLA_13_3_X miscellaneous code improvements from review of #42683
backport of #42574
backport of #42680
From the original PRs:
PR description:
This PR introduces a PCL-like workflow for SiStrip Lorentz Angle Monitoring (and potentially calibration), by using the
SiStripCalCosmics
dataset in input. The setup closesly resemble the one presented multiple times (see e.g. this talk) in which the hall mobility of the strips modules (only TIB and TOB for the time being, grouped in regions sharing same layer / module type) is estimated by fitting the distribution of the Strip cluster multiplicity as a function of the track grazing angle.The
SiStripCalCosmics
AlCaReco producer is added to theExpressCosmics
PD inautoAlCa
while the newPromptCalibProdSiStripLA
ALCAPrompt producer is introduced in several configuration files inConfiguration/StandardSequences
package.As a minimal follow-up, in order to be able to support uploads from the Prompt Calibration Loop:
DropBoxMetaData
writer and reader configuration filesSiStripLorentzAngle
workflow toCalibration/TkAlCaRecoProducers/test/testPCLAlCaHarvesting.py
PR validation:
Run the following command:
followed by:
and obtained reasonable output DQM and db files.
Also run successfully the augmented relval wf 1005.0 (
runTheMatrix.py -l 1005.0 -t 4 -j 8 --ibeos
.scram b runtests
runs fine.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Combined backport of #42574 and #42680
While this PR is not strictly needed for the rest of the 2023 data-taking ppRef / HI runs, it would be nice to have it included in the next 13.2.X (if that's possible) in order to profit of the testing machinery setup at Tier-0, in order to ask for a dedicated replay.