Fix heap-buffer-overflow in OnlineDQMDigiAD (#42445)

[iarspider]

PR description:

Apply fix from #42445 (comment)

PR validation:

Bot tests

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42756/36852

• This PR adds an extra 16KB to repository

[iarspider]

please test for CMSSW_13_3_ASAN_X

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• DQM/HcalTasks (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@bsunanda, @abdoulline, @DryRun this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a8587/34707/summary.html
COMMIT: 730c9c8
CMSSW: CMSSW_13_3_ASAN_X_2023-09-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42756/34707/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

The relvals timed out after 4 hours.

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a8587/34707/summary.html
COMMIT: 730c9c8
CMSSW: CMSSW_13_3_ASAN_X_2023-09-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42756/34707/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

The relvals timed out after 4 hours.

[emanueleusai]

please test for CMSSW_13_3_ASAN_X

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a8587/34727/summary.html
COMMIT: 730c9c8
CMSSW: CMSSW_13_3_ASAN_X_2023-09-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42756/34727/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

The relvals timed out after 4 hours.

[emanueleusai]

please test for CMSSW_13_3_ASAN_X

[iarspider]

I have cleaned up the commit history, no need to retest.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42756/37402

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #42756 was updated. @rvenditti, @tjavaid, @antoniovagnerini, @cmsbuild, @syuvivida, @nothingface0 can you please check and sign again.

[iarspider]

please test for CMSSW_13_3_ASAN_X

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a8587/35489/summary.html
COMMIT: e66179b
CMSSW: CMSSW_13_3_ASAN_X_2023-10-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42756/35489/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

The relvals timed out after 4 hours.

[iarspider]

Unit test no longer fails. @cms-sw/dqm-l2 could you please review and sign?

[smuzaffar]

please test

run tests for production IB/arch

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a8587/35494/summary.html
COMMIT: e66179b
CMSSW: CMSSW_13_3_X_2023-10-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42756/35494/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3362691
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3362660
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1