Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mu beamspot constrained pT. Increase mu eta and phi precision to 16 bits [13.1.X] #42786

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

namapane
Copy link
Contributor

PR description:

plain backport of #42646, as requested.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 14, 2023

A new Pull Request was created by @namapane (Nicola Amapane) for CMSSW_13_1_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • RecoMuon/GlobalTrackingTools (reconstruction)

@cmsbuild, @simonepigazzini, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@bellan, @AnnikaStein, @andrea21z, @abbiendi, @JanFSchulte, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @CeliaFernandez, @gpetruc, @trocino, @amagitte, @cericeci, @rociovilar this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@simonepigazzini
Copy link
Contributor

enable nano

@simonepigazzini
Copy link
Contributor

please test

@jfernan2
Copy link
Contributor

backport of #42646

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5a582/34756/summary.html
COMMIT: 16412d5
CMSSW: CMSSW_13_1_X_2023-09-14-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42786/34756/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3187380
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3187351
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 9.700000000000001 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 1.166 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.769 KiB Physics/NanoAODDQM
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 22 differences found in the comparisons
  • DQMHistoTests: Total files compared: 12
  • DQMHistoTests: Total histograms compared: 12351
  • DQMHistoTests: Total failures: 34
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 12317
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 10.841000000000001 KiB( 11 files compared)
  • DQMHistoSizes: changed ( 2500.311,... ): 1.166 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.331,... ): 0.769 KiB Physics/NanoAODDQM
  • Checked 25 log files, 11 edm output root files, 12 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.454 2.445 0.008 ( +0.3% ) 5.40 5.35 +1.0% 2.100 1.993
2500.311 2.586 2.552 0.034 ( +1.3% ) 4.83 4.82 +0.2% 2.430 2.002
2500.312 2.506 2.497 0.010 ( +0.4% ) 5.01 4.97 +0.9% 2.459 2.177
2500.33 1.251 1.240 0.011 ( +0.9% ) 10.15 10.09 +0.6% 2.131 2.110
2500.331 1.618 1.603 0.015 ( +0.9% ) 5.40 5.44 -0.6% 2.277 2.239
2500.332 1.500 1.485 0.015 ( +1.0% ) 7.62 7.71 -1.2% 2.227 2.191
2500.401 2.168 2.158 0.010 ( +0.5% ) 5.41 5.43 -0.3% 1.968 1.962
2500.501 1.768 1.762 0.007 ( +0.4% ) 9.27 9.27 +0.0% 1.849 1.845
2500.511 1.161 1.146 0.015 ( +1.3% ) 4.42 4.46 -0.7% 2.154 1.845
2500.5111 1.519 1.504 0.015 ( +1.0% ) 3.98 3.96 +0.7% 2.227 1.938
2500.601 2.035 2.025 0.010 ( +0.5% ) 13.06 13.20 -1.0% 1.897 1.728

@mandrenguyen
Copy link
Contributor

type muon

@mandrenguyen
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

  • Backport to intermediate release.

@cmsbuild cmsbuild merged commit 1642223 into cms-sw:CMSSW_13_1_X Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants