Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.2.X] Add 2D comparison histograms to SiStripMonitorApproximateCluster #42853

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 25, 2023

backport of #42852

PR description:

Somewhat inspired by this presentation, added 2D (underlying ROOT type TH2I) histograms to compare approximate and regular clusters for:

  • cluster size
  • cluster charge
  • cluster barycenter
  • first strip in cluster
  • last strip in cluster

PR validation:

Tested with the recipe at this gdoc:

scram project CMSSW_13_2_3
cd CMSSW_13_2_3/src
cmsenv
git cms-addpkg DQM/Integration

# in DQM/Integration/python/config/FrontierCondition_GT_cfi.py ( change GT here :  GlobalTag.globaltag = “132X_dataRun3_HLT_v2” )
# in DQM/Integration/python/config/inputsource_cfi.py change from  minEventsPerLumi = cms.untracked.int32(1), to minEventsPerLumi = cms.untracked.int32(100000)

scram b -j24
cmsRun DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py runInputDir=/eos/cms/store/group/phys_heavyions/prverma/HIDQM/streamers_CMSSW_13_2_3/ runNumber=362321 runkey=hi_run scanOnce=True

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #42852 for 2023 HI data-taking.

Compare approximate and regular clusters for:
- cluster size
- cluster charge
- cluster barycenter
- first strip in cluster
- last strip in cluster
@mmusich mmusich changed the title Add 2D comparison histograms to SiStripMonitorApproximateCluster [13.2.X] Add 2D comparison histograms to SiStripMonitorApproximateCluster Sep 25, 2023
@cmsbuild cmsbuild added this to the CMSSW_13_2_X milestone Sep 25, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 25, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X.

It involves the following packages:

  • DQM/SiStripMonitorApproximateCluster (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @jandrea this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 25, 2023

test parameters:

  • addpkg = DQM/Integration

@mmusich
Copy link
Contributor Author

mmusich commented Sep 25, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af7a2a/34881/summary.html
COMMIT: 9c23154
CMSSW: CMSSW_13_2_X_2023-09-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42853/34881/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198243
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198211
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@syuvivida
Copy link
Contributor

+1
tested and deployed at p5

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 584ea50 into cms-sw:CMSSW_13_2_X Sep 26, 2023
1 check passed
@mmusich mmusich deleted the mm_dev_SiStripMonitorApproxClusterUpdate_13_2_X branch September 26, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants