[13_2_X] Fix LHCInfoPerLS PopCon incorrectly matching LS between OMS and PPS db and fix LHCInfoPer* PopCons not recoginizing ongoing fills in duringFill mode

[JanChyczynski]

PR description:

Backport of #42629
and
Backport of #42837
#42837 depends on #42629 so they have to be backported together

See master PRs for descriptions

PR validation:

See master PRs

Backporting

Backport of #42629
and
Backport of #42837

[cmsbuild]

A new Pull Request was created by @JanChyczynski (jan_chyczynski) for CMSSW_13_2_X.

It involves the following packages:

• CondTools/RunInfo (db)

@saumyaphor4252, @cmsbuild, @perrotta, @francescobrivio, @consuegs can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[JanChyczynski]

Should I squash the 2 commits into one or as it's a backport of 2 PR's it's more clean if they're in separate commits?

[francescobrivio]

Should I squash the 2 commits into one or as it's a backport of 2 PR's it's more clean if they're in separate commits?

I think it's more clear to have two separate commits.

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2af98/34941/summary.html
COMMIT: 1a1b777
CMSSW: CMSSW_13_2_X_2023-09-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42888/34941/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3198243
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3198215
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+db

• The comparison with the corresponding code in master was not straightforward because fixed comparePayloads in LHCInfo* PopCons #42360 was only partially backported in 13_2_X with [13_2_X] fixed comparePayloads in LHInfo* PopCons #42361 (which was indeed my suggestion at the time, since I did not imagine that some further fix would have been still backported into the HI release...)
• However, the backported parts are correct, and faithfully reproduce what is in the master PRs fixed LHCInfoPer* PopCons not recoginizing ongoing fills in duringFill mode #42837 and Fix LHCInfoPerLS PopCon incorrectly matching LS between OMS and PPS db #42629
• bot tests show no issues

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1