Pythia8 interface fix which is really working this time

[tomcornelis]

When the bug in Pythia8 flat QCD weights was found, it was suggested to copy the Pythia8Interface from CMSSW_4_4_7 to fix it (#3853). Even though it compiled nicely, the fix introduced some pythia8 initialization problems, probably due to name changes of functions in GeneratorInterface/Core, I think.

Therefore I made this new fix where I revert Pythia8Hadronizer.cc back to the former version and only updated the sections which deal with the weights. So this is a more minimal fix, as was actually suggested by Josh before. I have tested it with our generator fragments, and it is really working this time.

[cmsbuild]

A new Pull Request was created by @UAEDF-tomc (Tom Cornelis) for CMSSW_4_2_X.

Pythia8 interface fix which is really working this time

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar, @nclopezo, @davidlt, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[bendavid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_4_2_X IBs unless changes or unless it breaks tests. @smuzaffar, @nclopezo, @davidlt, @ktf can you please take care of it?

[bendavid]

(Every time we build a 42x release a puppy dies keep in mind.)

[tomcornelis]

Any idea when the next CMSSW_4_2_10_patch2 will be build?

[vciulli]

there wasn’t any ORP meeting this week but maybe we can push for it by email

On 25 Jun 2014, at 13:26, Tom Cornelis notifications@github.com wrote:

Any idea when the next CMSSW_4_2_10_patch2 will be build?

—
Reply to this email directly or view it on GitHub.

[davidlange6]

its already known - but for some reason 710 and 720pre1 have gotten priority…

On Jun 25, 2014, at 2:09 PM, Vitaliano Ciulli notifications@github.com
wrote:

there wasn’t any ORP meeting this week but maybe we can push for it by email

On 25 Jun 2014, at 13:26, Tom Cornelis notifications@github.com wrote:

Any idea when the next CMSSW_4_2_10_patch2 will be build?

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.