Do not use size() - 1 in HLTL1TMatchedJetsVBFFilter [13_3_X]

[missirol]

backport of #43324

From the description of #43324:

This PR fixes a bug introduced by me in #42543, spotted by @mmusich (see #43300 (comment)). This bug led to failures in a few RelVals [*] after the integration of #43300 (first HLT menus using the buggy plugin).

The issue is that in

cmssw/HLTrigger/JetMET/plugins/HLTL1TMatchedJetsVBFFilter.h

Line 174 in 9e9d289

for (unsigned int i = 0; i < jetIndices.size() - 1; i++) {

jetIndices.size() - 1 is converted to unsigned int, so it becomes (uint) -1 (i.e. 4294967295), which is unintended.

In this particular case, it is sufficient to remove the -1 in the loop range: this removes the bug, and does not change the overall behaviour of the plugin. (The extra cost of the additional iteration when size > 0 is mostly likely minuscule.)

To be backported down to 13_2_X (where the buggy plugin was introduced).

Merely technical. No changes expected.

[*] RelVals with seg-faults in CMSSW_14_0_X_2023-11-17-2300 and CMSSW_13_3_X_2023-11-17-2300

141.001,141.008,141.008505,141.008511,141.008521,141.11,141.112

These RelVals did not fail in CMSSW_13_2_X_2023-11-17-2300, because in that cycle the same RelVals use the frozen HLT menu "2023-v1.2" (which has not changed recently, and does not use the buggy plugin).

PR validation:

None beyond the check done for #43324.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#43324

Bugfix of a plugin used at HLT.

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_3_X.

It involves the following packages:

• HLTrigger/JetMET (hlt)

@cmsbuild, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Do not use size() - 1 in HLTL1TMatchedJetsVBFFilter #43324

[mmusich]

test parameters

• workflows = 141.001, 141.008, 141.008505, 141.008511, 141.008521, 141.11, 141.112

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70d8a3/35939/summary.html
COMMIT: 6f5370a
CMSSW: CMSSW_13_3_X_2023-11-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43325/35939/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 619 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 140 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3362836
• DQMHistoTests: Total failures: 1792
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361022
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 228 log files, 174 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mmusich]

type bug-fix

[mmusich]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1