Add jet collections to GTT framework

[cgsavard]

PR description:
This PR adds two new jet collections for studying track jet performance:

tpfastjets clusters tracking particles with the fast jet algorithm
trutrkfastjets clusters L1 tracks with truth information with the fast jet algorithm

PR validation:
I have checked that the producers work correctly with the L1TrackObjectNtupleMaker and have run the necessary code checks.

These changes were checked by L1T in this PR here where I was told to make a corresponding PR into CMSSW.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43351/37816

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43351/37816/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43351/37816/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43351/37817

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @cgsavard for master.

It involves the following packages:

• L1Trigger/L1TTrackMatch (upgrade, l1)

@epalencia, @srimanob, @aloeliger, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76d9eb/35999/summary.html
COMMIT: 19b84ba
CMSSW: CMSSW_14_0_X_2023-11-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43351/35999/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cgsavard]

@aloeliger Ah yes, I have now removed the variable

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43351/37838

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #43351 was updated. @epalencia, @srimanob, @aloeliger, @cmsbuild can you please check and sign again.

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76d9eb/36014/summary.html
COMMIT: 13e0409
CMSSW: CMSSW_14_0_X_2023-11-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43351/36014/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 375 lines to the logs
• Reco comparison results: 137 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363868
• DQMHistoTests: Total failures: 1791
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3362055
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

• reviewed by L1 in the phase 2 fork: Add jet collections cms-l1t-offline/cmssw#1171

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1