Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7 1 x photon #4337

Merged
merged 7 commits into from
Jul 4, 2014
Merged

Conversation

monttj
Copy link
Contributor

@monttj monttj commented Jun 21, 2014

This is forward port to 71X from #4330.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @monttj (Tae Jeong Kim) for CMSSW_7_1_X.

7 1 x photon

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #4337 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

@monttj
Copy link
Contributor Author

monttj commented Jun 22, 2014

+1
It was mergeable with CMSSW_7_1_X_2014-06-21-1400.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

@monttj- it no longer is mergeable… So needs to be rebased (I guess fallout from the headache of 7_1_0 in DataFormats/PatCandidates)

In any case, is this in 72X?

@monttj
Copy link
Contributor Author

monttj commented Jun 22, 2014

@davidlange6 - yes, it is due to DataFormats/PatCandidates. Now it is mergeable.

@cmsbuild
Copy link
Contributor

Pull request #4337 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

@monttj
Copy link
Contributor Author

monttj commented Jun 22, 2014

And it is not in 72X yet.

@monttj
Copy link
Contributor Author

monttj commented Jun 23, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

@ktf, @nclopezo - could we rerun the tests on this PR?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2014

Pull request #4337 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

@nclopezo
Copy link
Contributor

nclopezo commented Jul 4, 2014

Hi David,
The tests for this PR are now in the queue.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2014

@davidlange6
Copy link
Contributor

was signed before being bumped for testing - will merge

davidlange6 added a commit that referenced this pull request Jul 4, 2014
@davidlange6 davidlange6 merged commit 24b0249 into cms-sw:CMSSW_7_1_X Jul 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants