Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move relval2023 to point to HLT frozen menu 2023v12 #43392

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Move relval2023 to point to HLT frozen menu 2023v12

PR validation:

TSG tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport but 13_3 specific!

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_13_3_X.

It involves the following packages:

  • Configuration/HLT (hlt)

@Martin-Grunewald, @mmusich, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @silviodonato, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3cf1e/36063/summary.html
COMMIT: 550b960
CMSSW: CMSSW_13_3_X_2023-11-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43392/36063/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 207 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 184 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3352820
  • DQMHistoTests: Total failures: 13586
  • DQMHistoTests: Total nulls: 82
  • DQMHistoTests: Total successes: 3339130
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -807.88 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): -196.482 KiB HLT/TAU
  • DQMHistoSizes: changed ( 12434.0,... ): -51.651 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 12434.0,... ): -6.930 KiB HLT/Filters
  • DQMHistoSizes: changed ( 141.044 ): -35.762 KiB HLT/TAU
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 3 / 48 workflows

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor

mmusich commented Nov 27, 2023

DQMHistoTests: Total failures: 13586

just pointing out for the record that since this PR has effectively downgraded the menu from the current state of the art to the last version used online in 2023 (intentionally!), for example it removes the tracking doublet recovery iteration and hence all the plots introduced in #42266 are now empty (see e.g https://tinyurl.com/ywyh8f8g).

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3fe5f8c into cms-sw:CMSSW_13_3_X Nov 27, 2023
10 checks passed
@mmusich mmusich deleted the MoveToFrozenMenu133 branch November 27, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants