-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.3.X] fix HLT track collection for SiStrip at HLT monitoring #43426
[13.3.X] fix HLT track collection for SiStrip at HLT monitoring #43426
Conversation
type bug-fix |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_3_X. It involves the following packages:
@syuvivida, @rvenditti, @antoniovagnerini, @cmsbuild, @Martin-Grunewald, @tjavaid, @mmusich, @nothingface0 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b4321/36146/summary.html Comparison SummarySummary:
|
+hlt
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #43385
PR description:
I casually noticed that in online DQM HLT on-track SiStrip quantities are empty (see e.g. here), while reviewing the TSG ticket CMSHLT-2766.
I think this is due to the fact that in the configuration file an not-existent track collection (
hltTracksMerged
instead ofhltMergedTracks
) is passed to the track refitter:cmssw/DQM/HLTEvF/python/HLTSiStripMonitoring_cff.py
Line 226 in c4e98e9
I fix this here, while also removing where possible redundant cms type specifications
PR validation:
cmssw
compilesIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
verbatim backport of #43385