Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.3.X] fix HLT track collection for SiStrip at HLT monitoring #43426

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 29, 2023

backport of #43385

PR description:

I casually noticed that in online DQM HLT on-track SiStrip quantities are empty (see e.g. here), while reviewing the TSG ticket CMSHLT-2766.
I think this is due to the fact that in the configuration file an not-existent track collection (hltTracksMerged instead of hltMergedTracks) is passed to the track refitter:

hltTrackRefitterForSiStripMonitorTrack.src = cms.InputTag("hltTracksMerged") # hltIter2Merged

I fix this here, while also removing where possible redundant cms type specifications

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #43385

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2023

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_3_X.

It involves the following packages:

  • DQM/HLTEvF (hlt, dqm)

@syuvivida, @rvenditti, @antoniovagnerini, @cmsbuild, @Martin-Grunewald, @tjavaid, @mmusich, @nothingface0 can you please review it and eventually sign? Thanks.
@missirol, @silviodonato, @mtosi this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b4321/36146/summary.html
COMMIT: 769bcaa
CMSSW: CMSSW_13_3_X_2023-11-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43426/36146/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2023

+hlt

@tjavaid
Copy link

tjavaid commented Nov 30, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e0c81f9 into cms-sw:CMSSW_13_3_X Dec 4, 2023
10 checks passed
@mmusich mmusich deleted the fix_track_collection_in_HLT_SiStripMonitoring_13_3_X branch December 4, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants