Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.3.X] Fix SiStripHashedDetId constructor / operator and add more SiStripLorentzAngle PCL unit testings #43481

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 2, 2023

backport of #43469

PR description:

This PR is a follow up to #43423 and implements several different fixes and improvements.
First it fixes the SiStripHashedDetId class, both in terms of the copy constructor (472005b) and assignment operator (f1ec80b). It also adds a new size() public method (38ff1c8).
Then it adds a catch2-based unit test for basic SiStripHashedDetId operations (done in commits 3edaa3d, b1aa2dd, ff86f96).
Finally it improves the filling of the per-module histograms in SiStripLorentzAnglePCLMonitor (commits 3c324b4 and b956d97) as well as adding a dedicated unit test of both the AlCASkimming and AlCaHarvesting steps (00250a4).

PR validation:

The validation of this PR relies on running the augment battery of unit tests of this package.
Running scam b runtests returns

Creating test log file logs/slc7_amd64_gcc12/testing.log
Pass    1s ... CalibFormats/SiStripObjects/TestCalibFormatsSiStripObjects
Pass   11s ... CalibFormats/SiStripObjects/testSiStripHashedDetId
Pass    0s ... CalibFormats/SiStripObjects/test_catch2_SiStripHashedDetId
Pass   58s ... CalibTracker/SiStripLorentzAngle/testPromptCalibProdSiStripLA
>> Test sequence completed for CMSSW CMSSW_13_3_X_2023-12-02-1100

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #43469 in case there is prolonged cosmics data-taking in 13_3_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_3_X.

It involves the following packages:

  • CalibFormats/SiStripObjects (alca)
  • CalibTracker/SiStripLorentzAngle (alca)

@consuegs, @perrotta, @cmsbuild, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@thomreis, @ReyerBand, @threus, @echabert, @tocheng, @gbenelli, @robervalwalsh, @wang0jin, @yuanchao, @rsreds, @mmusich, @argiro, @rchatter this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 2, 2023

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Dec 3, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-164115/36284/summary.html
COMMIT: ff86f96
CMSSW: CMSSW_13_3_X_2023-12-03-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43481/36284/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Dec 4, 2023

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 199042b into cms-sw:CMSSW_13_3_X Dec 4, 2023
10 checks passed
@mmusich mmusich deleted the mm_dev_addSiStripLorentzAnglePCL_unit_tests_13_3_X branch December 4, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants