-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.3.X] Fix SiStripHashedDetId
constructor / operator and add more SiStripLorentzAngle PCL unit testings
#43481
[13.3.X] Fix SiStripHashedDetId
constructor / operator and add more SiStripLorentzAngle PCL unit testings
#43481
Conversation
…d more per-module histograms
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_3_X. It involves the following packages:
@consuegs, @perrotta, @cmsbuild, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bug-fix |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-164115/36284/summary.html Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #43469
PR description:
This PR is a follow up to #43423 and implements several different fixes and improvements.
First it fixes the
SiStripHashedDetId
class, both in terms of the copy constructor (472005b) and assignment operator (f1ec80b). It also adds a newsize()
public method (38ff1c8).Then it adds a
catch2
-based unit test for basicSiStripHashedDetId
operations (done in commits 3edaa3d, b1aa2dd, ff86f96).Finally it improves the filling of the per-module histograms in SiStripLorentzAnglePCLMonitor (commits 3c324b4 and b956d97) as well as adding a dedicated unit test of both the AlCASkimming and AlCaHarvesting steps (00250a4).
PR validation:
The validation of this PR relies on running the augment battery of unit tests of this package.
Running
scam b runtests
returnsIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport of #43469 in case there is prolonged cosmics data-taking in 13_3_X.