Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle zero-events nanoAOD files [13.0.X] #43536

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

namapane
Copy link
Contributor

PR description:

Plain backport of #43533.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 10, 2023

A new Pull Request was created by @namapane (Nicola Amapane) for CMSSW_13_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @vlimant, @simonepigazzini can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor

vlimant commented Jan 16, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Jan 16, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3805d0/36858/summary.html
COMMIT: 31bbfd0
CMSSW: CMSSW_13_0_X_2024-01-14-0000/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43536/36858/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 12
  • DQMHistoTests: Total histograms compared: 12520
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 12520
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 11 files compared)
  • Checked 25 log files, 11 edm output root files, 12 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.469 2.469 0.000 ( +0.0% ) 5.38 5.39 -0.2% 2.089 2.090
2500.311 2.610 2.610 0.000 ( +0.0% ) 4.86 4.84 +0.5% 2.518 2.514
2500.312 2.522 2.522 0.000 ( +0.0% ) 5.02 4.97 +1.2% 2.499 2.500
2500.33 1.264 1.264 0.000 ( +0.0% ) 10.25 10.28 -0.3% 2.212 2.210
2500.331 1.634 1.634 0.000 ( +0.0% ) 5.46 5.45 +0.2% 2.403 2.395
2500.332 1.516 1.516 0.000 ( +0.0% ) 7.87 7.86 +0.1% 2.311 2.311
2500.401 2.126 2.126 0.000 ( +0.0% ) 5.45 5.43 +0.5% 1.951 1.950
2500.501 1.731 1.731 0.000 ( +0.0% ) 9.33 9.35 -0.2% 1.833 1.830
2500.511 1.125 1.125 0.000 ( +0.0% ) 4.51 4.46 +1.2% 2.193 2.153
2500.5111 1.479 1.479 0.000 ( +0.0% ) 3.99 3.97 +0.4% 2.231 2.231
2500.601 1.991 1.991 0.000 ( +0.0% ) 13.11 13.09 +0.1% 1.878 1.874

@vlimant
Copy link
Contributor

vlimant commented Jan 17, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 395f297 into cms-sw:CMSSW_13_0_X Jan 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants