Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4 Bug Fix] Remove GenFilter when pgen_smear is used #43562

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

srimanob
Copy link
Contributor

PR description:

Backport of #43561

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild cmsbuild added this to the CMSSW_12_4_X milestone Dec 13, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2023

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/Applications (operations)

@antoniovilela, @fabiocos, @davidlange6, @cmsbuild, @rappoccio can you please review it and eventually sign? Thanks.
@makortel, @fabiocos, @missirol, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@srimanob
Copy link
Contributor Author

srimanob commented Dec 13, 2023

urgent

Need for production.

@srimanob
Copy link
Contributor Author

@cms-sw/orp-l2

We just fix this. Would it be possible to merge it when PR passes the test (both master and here), and make new release for 12_4? This will need for production.
FYI @drkovalskyi

@drkovalskyi
Copy link
Contributor

We would like to get it into production asap so that we can use the holiday break to process a special background sample that is need for the new muon identification, used in Run3 analysis aiming Winter conferences.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e7a81/36478/summary.html
COMMIT: 6d369ae
CMSSW: CMSSW_12_4_X_2023-12-10-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43562/36478/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3766053
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 5e5ee7a into cms-sw:CMSSW_12_4_X Dec 15, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants