Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PixelTrackCleanerWrapper for quadruplet SeedingHitSet #4372

Merged

Conversation

makortel
Copy link
Contributor

PixelTrackCleanerWrapper assumed SeeingHitSets have 2 or 3 hits, resulting in pixel tracks that have 3 hits although they were reconstructed from quadruplets. Fixed by storing also the 4th hit if there is one.

Should not affect on pt/eta/etc of pixel tracks because the cleaning is done after the fit, but distributions sensitive to the number of hits may be affected.

FYI @thokc @cerati @rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_6_2_X_SLHC.

Fix PixelTrackCleanerWrapper for quadruplet SeedingHitSet

It involves the following packages:

RecoPixelVertexing/PixelTrackFitting

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@VinInn
Copy link
Contributor

VinInn commented Jun 26, 2014

ping...
no test?

@ktf
Copy link
Contributor

ktf commented Jun 26, 2014

I just started it.

On 26 Jun 2014, at 14:48, Vincenzo Innocente wrote:

ping...
no test?


Reply to this email directly or view it on GitHub:
#4372 (comment)

@cmsbuild
Copy link
Contributor

@fratnikov
Copy link

merge
tested on single pions. Known problems in harvesting for HGCal configurations

cmsbuild added a commit that referenced this pull request Jun 27, 2014
…slhc

Fix PixelTrackCleanerWrapper for quadruplet SeedingHitSet
@cmsbuild cmsbuild merged commit e081692 into cms-sw:CMSSW_6_2_X_SLHC Jun 27, 2014
makortel added a commit to makortel/cmssw that referenced this pull request Dec 6, 2014
makortel pushed a commit to makortel/cmssw that referenced this pull request Jan 30, 2015
@makortel makortel deleted the pixelTrackCleanerQuadruplet_62slhc branch October 20, 2016 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants