Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmsDriver option --maxmem_profile to prefix LD_PRELOAD="libPerfToolsAllocMonitorPreload.so libPerfToolsMaxMemoryPreload.so" to cmsRun #44001

Merged

Conversation

gartung
Copy link
Member

@gartung gartung commented Feb 16, 2024

Addresses cms-sw/framework-team#671

Add cmsDriver option --maxmem_profile to prefix LD_PRELOAD="libPerfToolsAllocMonitorPreload.so libPerfToolsMaxMemoryPreload.so" to cmsRun

…olsAllocMonitorPreload.so libPerfToolsMaxMemoryPreload.so" to cmsRun
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 16, 2024

cms-bot internal usage

@gartung gartung marked this pull request as ready for review February 16, 2024 19:57
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44001/38921

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung for master.

It involves the following packages:

  • Configuration/Applications (operations)

@fabiocos, @rappoccio, @cmsbuild, @davidlange6, @antoniovilela can you please review it and eventually sign? Thanks.
@missirol, @fabiocos, @makortel, @Martin-Grunewald this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

Are there enough hooks in runTheMatrix that this new cmsDriver option can be easily passed for all steps of all workflows in PR tests?

@gartung
Copy link
Member Author

gartung commented Feb 16, 2024

I don't know. But first I have to determine what causes this error

cmsDriver.py: error: argument --maxmem_profile: expected one argument

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44001/38923

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44001 was updated. @antoniovilela, @fabiocos, @davidlange6, @rappoccio, @cmsbuild can you please check and sign again.

@makortel
Copy link
Contributor

How/where are the other profiling options passed in the profiling IB/PR jobs?

@gartung
Copy link
Member Author

gartung commented Feb 16, 2024

runTheMatrix.py $WF --command " -n $EVENTS --profile $prof --customise Validation/Performance/IgProfInfo.customise --no_exec"
The --profile $prof is the argument that gets converted to a cmsDriver.py argumnent,.

@gartung
Copy link
Member Author

gartung commented Feb 28, 2024

please test with cms-sw/cms-bot#2185

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46f60f/37801/summary.html
COMMIT: 8a8e495
CMSSW: CMSSW_14_1_X_2024-02-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44001/37801/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@gartung
Copy link
Member Author

gartung commented Feb 29, 2024

please test with cms-sw/cms-bot#2185

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46f60f/37813/summary.html
COMMIT: 8a8e495
CMSSW: CMSSW_14_1_X_2024-02-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44001/37813/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@gartung
Copy link
Member Author

gartung commented Mar 1, 2024

please test with cms-sw/cms-bot#2185

@gartung
Copy link
Member Author

gartung commented Mar 1, 2024

Example of the variance from the last five completed runTheMatrix test workflow 25034.999

[gartung@cmsdev25 PR-46f60f]$ tail -n6 */runTheMatrix-results/25034.999*/step3*.log
==> 37781/runTheMatrix-results/25034.999_TTbar_14TeV+2026D98PU_PMXS1S2PR/step3_TTbar_14TeV+2026D98PU_PMXS1S2PR.log <==
Memory Report
  total memory requested: 178127362204
  max memory used: 3888251584
  presently used: 659294632
  # allocations calls:   1649760412
  # deallocations calls: 1648912864

==> 37793/runTheMatrix-results/25034.999_TTbar_14TeV+2026D98PU_PMXS1S2PR/step3_TTbar_14TeV+2026D98PU_PMXS1S2PR.log <==
Memory Report
  total memory requested: 178125038615
  max memory used: 3888251360
  presently used: 659294616
  # allocations calls:   1649758031
  # deallocations calls: 1648910484

==> 37798/runTheMatrix-results/25034.999_TTbar_14TeV+2026D98PU_PMXS1S2PR/step3_TTbar_14TeV+2026D98PU_PMXS1S2PR.log <==
Memory Report
  total memory requested: 178128497624
  max memory used: 3888251456
  presently used: 659294616
  # allocations calls:   1649762203
  # deallocations calls: 1648914656

==> 37801/runTheMatrix-results/25034.999_TTbar_14TeV+2026D98PU_PMXS1S2PR/step3_TTbar_14TeV+2026D98PU_PMXS1S2PR.log <==
Memory Report
  total memory requested: 178126101922
  max memory used: 3888250096
  presently used: 659293400
  # allocations calls:   1649761266
  # deallocations calls: 1648913721

==> 37813/runTheMatrix-results/25034.999_TTbar_14TeV+2026D98PU_PMXS1S2PR/step3_TTbar_14TeV+2026D98PU_PMXS1S2PR.log <==
Memory Report
  total memory requested: 178175229722
  max memory used: 3903582880
  presently used: 674592408
  # allocations calls:   1649958856
  # deallocations calls: 1649044997

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46f60f/37857/summary.html
COMMIT: 8a8e495
CMSSW: CMSSW_14_1_X_2024-03-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44001/37857/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cms-bot#2185

@cmsbuild cmsbuild merged commit 1f01765 into cms-sw:master Mar 4, 2024
12 checks passed
@gartung gartung deleted the gartung-maxmempreload-cmsdriveropion branch March 4, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants