Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex176C Backport the PR's 44006 and 44052 for the 2024 scenario definition with additional chambers for GE21 and iRPC #44053

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

bsunanda
Copy link
Contributor

PR description:

Backport the PRs 44006 and 44052 for the 2024 scenario definition with additional chambers for GE21 and iRPC

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backports of #44006 and #44052

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/MuonCommonData (geometry)

@bsunanda, @mdhildreth, @antoniovilela, @Dr15Jones, @civanch, @makortel, @subirsarkar, @rappoccio, @cmsbuild, @davidlange6, @fabiocos, @srimanob can you please review it and eventually sign? Thanks.
@mtosi, @dgulhan, @JanFSchulte, @mmusich, @watson-ij, @sameasy, @VourMa, @missirol, @makortel, @rovere, @GiacomoSguazzoni, @felicepantaleo, @vargasa, @slomeo, @VinInn, @ptcox, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2024

cms-bot internal usage

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3c686/37617/summary.html
COMMIT: e1eee45
CMSSW: CMSSW_14_0_X_2024-02-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44053/37617/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@bsunanda
Copy link
Contributor Author

+geometry

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

Pull request #44053 was updated. @bsunanda, @mdhildreth, @antoniovilela, @cmsbuild, @rappoccio, @Dr15Jones, @makortel, @civanch, @fabiocos, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@bsunanda
Copy link
Contributor Author

+geometry

@bsunanda
Copy link
Contributor Author

@rappoccio, @antoniovilela Could you please merge this PR?

@rappoccio
Copy link
Contributor

@bsunanda maybe we don't need a ping on a PR you signed 30 seconds earlier and well before the tests are even completed? Just a thought.

@rappoccio
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@rappoccio
Copy link
Contributor

I'll put this on hold until tests complete, just to be sure we don't accidentally merge it prematurely.

@cmsbuild cmsbuild added the hold label Feb 29, 2024
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3c686/37815/summary.html
COMMIT: a0e2e8c
CMSSW: CMSSW_14_0_X_2024-02-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44053/37815/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@bsunanda
Copy link
Contributor Author

bsunanda commented Mar 4, 2024

@rappoccio @antoniovilela Please uphold this PR and merge this to 14_0_X

@rappoccio
Copy link
Contributor

unhold

@rappoccio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit a0a5877 into cms-sw:CMSSW_14_0_X Mar 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants