Run3-gex176D Modify the RPC numbering scheme to avoid wrong DetId assignment #44065
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44065/39014
|
|
A new Pull Request was created by @bsunanda for master. It involves the following packages:
@civanch, @cmsbuild, @Dr15Jones, @srimanob, @bsunanda, @mdhildreth, @makortel, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f79e1/37650/summary.html Comparison SummarySummary:
|
| @@ -252,7 +252,7 @@ | |||
| 'Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml', | |||
| )+ | |||
| cms.vstring( | |||
| 'Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml', | |||
There was a problem hiding this comment.
@bsunanda , are you sure if we need this file? For me would be OK if these type of files are changed only for Run-3 legacy.
| @@ -252,7 +252,7 @@ | |||
| 'Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml', | |||
| )+ | |||
| cms.vstring( | |||
| 'Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml', | |||
| 'Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml', | |||
There was a problem hiding this comment.
@bsunanda , why not ...../muonNumbering/2024/v1/muonNumbering.xml ?
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-approved
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44065/39038 |
|
Pull request #44065 was updated. @mdhildreth, @bsunanda, @civanch, @Dr15Jones, @cmsbuild, @srimanob, @subirsarkar, @makortel can you please check and sign again. |
|
@cmsbuild Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f79e1/37663/summary.html Comparison SummarySummary:
|
|
+1 |
|
@srimanob , @subirsarkar, please, review this PR. |
|
Hi @civanch I don't think we can review on XML file without study result. Do we have study from RPC to confirm this? I would prefer to have it attach to this PR. Thanks. |
|
+Upgrade Propose to merge as request in #44065 (comment) However, I still think that the confirmation of RPC is needed to attach to the PR. I don't think it is healthy to merge PR with only wording on removing crash. PR description does not explain anything to fix issue and how to test. Note that, this PR can't be tested with short or long matrix as we don't have a workflow to handle XML geometry for Run-3. From the email discussion with RPC, I understand that we should see something from RPC. |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
@srimanob , it was agreed at https://indico.cern.ch/event/1387191/ that we do not produce DB pilot and backports to 14_0 until green light from RPC and GEM DPG. This PR should be merge to go faster in this direction. |
|
urgent |
|
By the way, should this pr be squashed first? So that we don't have history of 2021/v6 anymore. Maybe not, as it is filename change, not delete. |
|
+1 |
PR description:
Modify the RPC numbering scheme to avoid wrong DetId assignment
PR validation:
Avoid crash in the DIgin step due to RPC wrong DetId
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Need to be back ported to 14_0_X