Simple HGC Clustering and HGC GsfElectrons #4418
Conversation
|
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC. Simple HGC Clustering and HGC GsfElectrons It involves the following packages: RecoEcal/EgammaClusterAlgos @civanch, @nclopezo, @mdhildreth, @cmsbuild, @StoyanStoynev, @slava77, @Degano can you please review it and eventually sign? Thanks. |
| int detector = scl.seed()->hitsAndFractions()[0].first.subdetId() ; | ||
| if (detector==EcalBarrel && (had<maxHBarrel_ || had/scle<maxHOverEBarrel_)) HoeVeto=true; | ||
| else if (detector==EcalEndcap && (had<maxHEndcaps_ || had/scle<maxHOverEEndcaps_)) HoeVeto=true; | ||
| else if (component==DetId::Forward && detector==HGCEE && (had<maxHEndcaps_ || had/scle<maxHOverEEndcaps_)) HoeVeto=true; |
There was a problem hiding this comment.
I guess this "if" chain should first select appropriate det() and only then test subdetId()
There was a problem hiding this comment.
Hi Fedor, I agree that logic would be cleaner, but given that this code operates on super-clusters (where the data volume is significantly reduced) it makes no difference in performance.
|
merge Checked with 4 muons and pions (cmsbuild currently doesn't test the newer geometries including, I believe, HGCal). Only the known failures in HGCal harvesting. |
|
Pull request #4418 was updated. @civanch, @nclopezo, @mdhildreth, @cmsbuild, @alja, @Dr15Jones, @StoyanStoynev, @slava77, @Degano, @ktf can you please check and sign again. |
Simple HGC Clustering and HGC GsfElectrons
@vandreev11 @pfs @amagnan @bsunanda
HGC Clustering and GsfElectrons as described in talks this week.
This has been made to work on the Valeri's latest change to store RecHit energies in GeV.