Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #44256 - merged too early #44292

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

iarspider
Copy link
Contributor

PR description:

#44256 was supposed to go with cms-sw/cmsdist#9034, but the latter is not yet ready.
Reverting to avoid breaking ROOT6 IBs.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44292/39313

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @hqucms can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf8dfc/37870/summary.html
COMMIT: 2bcf9bc
CMSSW: CMSSW_14_1_X_2024-03-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44292/37870/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf8dfc/37870/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf8dfc/37870/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 78 lines from the logs
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3338784
  • DQMHistoTests: Total failures: 33
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338729
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 120.264 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 12.837 KiB MTD/BTL
  • DQMHistoSizes: changed ( 23234.0,... ): 7.207 KiB MTD/ETL
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@vlimant
Copy link
Contributor

vlimant commented Mar 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 07bcc38 into cms-sw:master Mar 5, 2024
11 checks passed
@iarspider iarspider deleted the revert-44256 branch March 6, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants