-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMSSW_14_0_X ] Fix tag for the SiPixelLorentzAngleSimRcd in the Phase2 MC GT #44357
Conversation
A new Pull Request was created by @perrotta for CMSSW_14_0_X. It involves the following packages:
@perrotta, @cmsbuild, @saumyaphor4252, @consuegs can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
please test |
For the record despite the wrong tag name, the payload is actually the same, thus the old GT is not technically wrong. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e38da/37993/summary.html Comparison SummarySummary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
backport of #44356 |
type bug-fix |
+1 |
PR description:
Fix the phase2_realistic GT: in a previous update of that GT (ported to autoCond with #43763) a mistake slipped in because a wrong tag was taken for SiPixelLorentzAngleSimRcd. This is corrected in the
GT140X_mcRun4_realistic_v3
Relevant github issue describing the need to move the default phase2 geometry to D98 is still #42945
Modified tag:
SiPixelLorentzAngle_phase2_T25_v0_mc
toSiPixelSimLorentzAngle_phase2_T25_v0_mc
Difference with respect to the previous run4 MC GT:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
backport of #44356