Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSSW_14_0_X ] Fix tag for the SiPixelLorentzAngleSimRcd in the Phase2 MC GT #44357

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Mar 8, 2024

PR description:

Fix the phase2_realistic GT: in a previous update of that GT (ported to autoCond with #43763) a mistake slipped in because a wrong tag was taken for SiPixelLorentzAngleSimRcd. This is corrected in the GT140X_mcRun4_realistic_v3

Relevant github issue describing the need to move the default phase2 geometry to D98 is still #42945

Modified tag:

  • SiPixelLorentzAngleSimRcd from SiPixelLorentzAngle_phase2_T25_v0_mc to SiPixelSimLorentzAngle_phase2_T25_v0_mc

Difference with respect to the previous run4 MC GT:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #44356

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

A new Pull Request was created by @perrotta for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@perrotta, @cmsbuild, @saumyaphor4252, @consuegs can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @yuanchao, @Martin-Grunewald, @rsreds, @tocheng, @fabiocos this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor Author

perrotta commented Mar 8, 2024

please test

@mmusich
Copy link
Contributor

mmusich commented Mar 8, 2024

in because a wrong tag was taken for SiPixelLorentzAngleSimRcd.

For the record despite the wrong tag name, the payload is actually the same, thus the old GT is not technically wrong.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e38da/37993/summary.html
COMMIT: 1a66aac
CMSSW: CMSSW_14_0_X_2024-03-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44357/37993/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor Author

perrotta commented Mar 9, 2024

+alca

  • As pointed out by Marco this changes nothing in practice, while a tag with the exact name as originally requested by Tracker is replaced. Having passed the bot tests both in master and here in 14_0_X, it can be signed even without waiting for it being merged in master

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor Author

backport of #44356

@mmusich
Copy link
Contributor

mmusich commented Mar 10, 2024

type bug-fix

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cf3dd89 into cms-sw:CMSSW_14_0_X Mar 11, 2024
10 checks passed
@perrotta perrotta deleted the fixRun4140XGT_140X branch March 11, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants