-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] Backport - Refactor scatterer addition in aGblPoint to explicitly specify type for scatPrecision.inverse() #44359
Conversation
…or scatPrecision.inverse()
A new Pull Request was created by @sroychow for CMSSW_14_0_X. It involves the following packages:
@cmsbuild, @consuegs, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
test parameters:
|
@cmsbuild please test |
-1 Failed Tests: RelVals The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: RelValsValueError: Undefined workflows: 1001.4 |
test parameters:
|
Workflow 1001.4 is not defined in 14_0_X |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98eb90/38005/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
backport of #44340 |
urgent
|
+1 |
Backport of #44340. (thanks to @mmusich )
PR description:
Code compiles.