Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Backport - Refactor scatterer addition in aGblPoint to explicitly specify type for scatPrecision.inverse() #44359

Conversation

sroychow
Copy link
Contributor

@sroychow sroychow commented Mar 8, 2024

Backport of #44340. (thanks to @mmusich )

PR description:

Code compiles.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

A new Pull Request was created by @sroychow for CMSSW_14_0_X.

It involves the following packages:

  • Alignment/ReferenceTrajectories (alca)

@cmsbuild, @consuegs, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks.
@yuanchao, @rsreds, @mmusich, @tlampen, @adewit, @tocheng this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

cms-bot internal usage

@sroychow
Copy link
Contributor Author

sroychow commented Mar 8, 2024

test parameters:

@sroychow
Copy link
Contributor Author

sroychow commented Mar 8, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2024

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98eb90/38002/summary.html
COMMIT: 409969f
CMSSW: CMSSW_14_0_X_2024-03-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44359/38002/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98eb90/38002/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98eb90/38002/git-merge-result

RelVals

ValueError: Undefined workflows: 1001.4

@perrotta
Copy link
Contributor

perrotta commented Mar 9, 2024

test parameters:

@perrotta
Copy link
Contributor

perrotta commented Mar 9, 2024

Workflow 1001.4 is not defined in 14_0_X

@perrotta
Copy link
Contributor

perrotta commented Mar 9, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98eb90/38005/summary.html
COMMIT: 409969f
CMSSW: CMSSW_14_0_X_2024-03-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44359/38005/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Mar 9, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9057

@perrotta
Copy link
Contributor

backport of #44340

@sroychow
Copy link
Contributor Author

sroychow commented Mar 11, 2024

urgent

  • need a 140X release to run alignment campaigns for rereco + 2024 conditions

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c55fafc into cms-sw:CMSSW_14_0_X Mar 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants