Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLT phase-2: fix HGCAL Layercluster and create common constants configuration for HGCAL #44552

Merged
merged 2 commits into from
Mar 31, 2024
Merged

HLT phase-2: fix HGCAL Layercluster and create common constants configuration for HGCAL #44552

merged 2 commits into from
Mar 31, 2024

Conversation

felicepantaleo
Copy link
Contributor

This PR fixes a bug where the value of fCperElectron was accidentally set to 0. This caused noise hits to seed the creation of layerclusters.
In this PR I have moved all the constants to a common file, so it's easier to maintain.
I have also updated the constants to Calorimeter Geometry v16.

@rovere @SohamBhattacharya @waredjeb fyi

@felicepantaleo
- create a common hgcal reco pset for constants to be shared across h…
0e6a306 
…gcal reco modules at HLT

- fix a bug in fCPerEle
- update hgcal constants to v16 of the calorimeter geometry

centralize constants in HLT hgcalLayerClustersEE_cfi

centralize constants in HLT hgcalLayerClustersEEL1Seeded_cfi

centralize constants in HLT hgcalLayerClustersHSciL1Seeded_cfi

centralize constants in HLT hgcalLayerClustersHSci_cfi

centralize constants in HLT hgcalLayerClustersHSiL1Seeded_cfi

centralize constants in HLT hgcalLayerClustersHSi_cfi

centralize constants in HLT HGCalRecHitL1Seeded_cfi

centralize constants in HLT HGCalRecHit_cfi

centralize constants in HLT HGCalUncalibRecHitL1Seeded_cfi

centralize constants in HLT HGCalUncalibRecHit_cfi
@felicepantaleo
add trailing new line
abbd14d
@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Mar 27, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2024 •
edited
Loading

cms-bot internal usage

@felicepantaleo
Copy link
Contributor Author

@cmsbuild please test

@rovere
Copy link
Contributor

rovere commented Mar 27, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44552/39694

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @rovere, @SohamBhattacharya, @silviodonato this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dce553/38447/summary.html
COMMIT: abbd14d
CMSSW: CMSSW_14_1_X_2024-03-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44552/38447/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 96 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 238 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297857
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297823
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

@rovere rovere mentioned this pull request Mar 27, 2024
Merged
@mmusich
Copy link
Contributor

mmusich commented Mar 29, 2024

type hgcal

@cmsbuild cmsbuild added the hgcal label Mar 29, 2024
@mmusich
Copy link
Contributor

mmusich commented Mar 29, 2024

+hlt

  • bug-fix seems uncontroversial

@mmusich
Copy link
Contributor

mmusich commented Mar 29, 2024

@felicepantaleo please open a backport to 14.0.x as well

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4a6e02f into cms-sw:master Mar 31, 2024
11 checks passed
@cmsbuild cmsbuild mentioned this pull request Apr 1, 2024
Merged
@AuroraPerego AuroraPerego mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix code-checks-approved fully-signed hgcal hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
5 participants
@felicepantaleo @cmsbuild @rovere @mmusich @antoniovilela