Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #44546: Add QuadJet with 3 b-tag PNet trigger to the DQM offline #44553

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

brunolopesbr2
Copy link

PR description:

This is a backport of PR #44546 to 14_0_X, as it needs to be ready alongside the HLT menu v1.1.

Added the Particle Net migrated version of the QuadJet with 3 b-tag trigger to the offline DQM. This trigger path was approved by TSG on March 13th (https://indico.cern.ch/event/1389073/).

As pointed out in the JIRA CMSHLT-3119, the validation strategy should be the same as the previous version of the path (using DeepJet), so it was copied over from the top DQM code with the necessary parameter changes. It's now important only to the Exotica PAG, so it was included in the Exotica DQM.

PR validation:

The DQM code was validated using a runTheMatrix workflow (modified to use the new trigger path). The resulting DQM file was uploaded to the DQM GUI at http://dqm-dev-test.cern.ch:8060/dqm/dev/ and it's a RelVal file. In particular, check that the new DQM plots are being created at the new HLT/EXO/DisplacedVertices/* folder and are populated with the passing events.

A further local validation with fewer events was made to validate the backport to 14_0_X, which was straight-forward.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2024

A new Pull Request was created by @brunolopesbr2 for CMSSW_14_0_X.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@rvenditti, @syuvivida, @cmsbuild, @antoniovagnerini, @tjavaid, @nothingface0 can you please review it and eventually sign? Thanks.
@HuguesBrun, @jhgoh, @cericeci, @Fedespring, @rociovilar, @missirol, @mtosi, @trocino this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Mar 27, 2024

backport of #44546

@tjavaid
Copy link

tjavaid commented Mar 27, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85a1f2/38453/summary.html
COMMIT: c779dfb
CMSSW: CMSSW_14_0_X_2024-03-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44553/38453/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 109 lines to the logs
  • Reco comparison results: 35 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346148
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346123
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Apr 2, 2024

@cms-sw/dqm-l2 can you please review this? It would be good to have this integrated once we deliver the next HLT menu 2024 V1.1

@tjavaid
Copy link

tjavaid commented Apr 4, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 85d653a into cms-sw:CMSSW_14_0_X Apr 5, 2024
10 checks passed
@brunolopesbr2 brunolopesbr2 deleted the DV-DQM-14_0_X branch April 5, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants