fixup eta lookup in absEtaLowEdges_ in miscellaneous RecoEgamma/EgammaHLTProducers plugins

[mmusich]

resolves #44759

PR description:

Implements what's discussed in #44759 (comment) and #44759 (comment). Avoids bound check failures when having input candidate with eta() exactly equal to 0.

PR validation:

Run the following script:

#!/bin/bash -ex

# CMSSW_14_0_5_patch1

hltGetConfiguration run:379530 \
  --globaltag 140X_dataRun3_HLT_v3 \
  --data \
  --no-prescale \
  --no-output \
  --max-events -1 \
  --input /store/group/tsg/FOG/debug/2024-04-17_run379530/run379530_ls0556.root  > hlt.py
  
cat <<@EOF >> hlt.py
process.options.wantSummary = True

process.options.numberOfThreads = 1
process.options.numberOfStreams = 0
@EOF

cmsRun hlt.py &> hlt.log

in this branch and verified that there are no failures.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport but will be backported to CMSSW_14_0_X for 2024 data-taking purposes.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44764/39981

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• RecoEgamma/EgammaHLTProducers (hlt)

@cmsbuild, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@varuns23, @Fedespring, @a-kapoor, @valsdav, @ReyerBand, @ram1123, @argiro, @rchatter, @silviodonato, @wang0jin, @thomreis, @sobhatta, @HuguesBrun, @afiqaize, @missirol, @Sam-Harper, @cericeci, @lgray, @jainshilpi, @sameasy, @Prasant1993 this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-847814/38898/summary.html
COMMIT: dcf93bf
CMSSW: CMSSW_14_1_X_2024-04-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44764/38898/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 18 lines to the logs
• Reco comparison results: 2987 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319599
• DQMHistoTests: Total failures: 6038
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3313541
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[mmusich]

Reco comparison results: 2987 differences found in the comparisons

all the differences are found in an oddly specific wf 11634.0, and are IMHO too widespread to be caused by this PR.

[swagata87]

type egamma

[mmusich]

all the differences are found in an oddly specific wf 11634.0, and are IMHO too widespread to be caused by this PR.

I am seeing the same kind of comparison failures also in other PRs:

• Adding PNET scores to offline HLT DQM #44754 (comment)
• [14_1_X] [Phase-2] Changed Phase-2 JME and BTV HLT paths to use the L1 P2GT emulator #44751 (comment)

[mmusich]

+hlt

• differences seen in wf 11634.0 are spurious, see fixup eta lookup in absEtaLowEdges_ in miscellaneous RecoEgamma/EgammaHLTProducers plugins #44764 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

type bug-fix

[rappoccio]

+1