Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Phase2 tracker T36, T37 and T38 (for IT studies) #44765

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

Raffaella07
Copy link
Contributor

@Raffaella07 Raffaella07 commented Apr 17, 2024

PR description:

This PR introduces three new phase-2 Tracker layouts as presented in:
https://indico.cern.ch/event/1344694/contributions/5725063/attachments/2775549/4836942/DPG_TrackerSim_updates.pdf

T36:
Geometry scenario: 2026D111.
Workflows: 300xx .0

T37:
Geometry scenario: 2026D112.
Workflows: 304xx.0

T38:
Geometry scenario: 2026D113.
Workflows: 308xx.0

PR validation:

  • Checked XMLs make sense from Tracker design point of view
  • Checked workflow numbering
  • Checked that workflows with scenarios D111, D112 and D113 run smoothly with no errors
  • Warnings on L1NNCaloTauEmulator - BrokenTowers (step2) DQMGenericClient:postProcessorHLTmuonTracking@endRun (step4). Should not depend on tracker geometry, same exact warnings are present in D108 (tested wf 28824) in clean CMSSW_14_1_pre2.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

not a backport

@emiglior @mmusich @bsunanda @sroychow @ FYI

@cmsbuild
Copy link
Contributor

@Raffaella07, CMSSW_14_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44765/39982

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Raffaella07 for master.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/Geometry (geometry, upgrade)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/TrackerCommonData (geometry)
  • Geometry/TrackerNumberingBuilder (geometry)
  • Geometry/TrackerRecoData (geometry)
  • Geometry/TrackerSimData (geometry)

@antoniovilela, @subirsarkar, @saumyaphor4252, @rappoccio, @bsunanda, @makortel, @davidlange6, @civanch, @AdrianoDee, @srimanob, @cmsbuild, @mdhildreth, @sunilUIET, @fabiocos, @miquork, @Dr15Jones, @perrotta, @consuegs can you please review it and eventually sign? Thanks.
@mtosi, @rsreds, @slomeo, @missirol, @Martin-Grunewald, @VinInn, @mmusich, @ghugo83, @tocheng, @sameasy, @rovere, @JanFSchulte, @vargasa, @felicepantaleo, @venturia, @bsunanda, @dgulhan, @yuanchao, @GiacomoSguazzoni, @makortel, @VourMa, @fabiocos this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Apr 17, 2024

test parameters:

  • workflow_opts = -w upgrade
  • workflows = 22034.0, 30034 .0, 30434.0, 30034.0

@mmusich
Copy link
Contributor

mmusich commented Apr 17, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Apr 17, 2024

@cmsbuild, please abort

@emiglior
Copy link
Contributor

emiglior commented Apr 17, 2024

about the potential conflicts with PR 44576, my preference would be to give higher priority to this PR (44765)

@perrotta
Copy link
Contributor

+alca

@srimanob
Copy link
Contributor

+Upgrade

@civanch
Copy link
Contributor

civanch commented Apr 19, 2024

+1

@AdrianoDee
Copy link
Contributor

+pdmv

@emiglior
Copy link
Contributor

Hi, as providing these geometries is one of the items to be reported at the forthcoming TK Annual Review (Apr 29th) it would be really nice to have the PR fully signed by then...

@mmusich
Copy link
Contributor

mmusich commented Apr 23, 2024

@cms-sw/orp-l2 your signature is required here.

@rappoccio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants