Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PU weighting (70x) #4508

Merged
merged 1 commit into from
Jul 15, 2014
Merged

PU weighting (70x) #4508

merged 1 commit into from
Jul 15, 2014

Conversation

jpavel
Copy link
Contributor

@jpavel jpavel commented Jul 3, 2014

Backport of #4131.

Adds option to run weighted isolation, no changes expected in default running. All documentation in #4131

@bachtis, @monttj

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2014

A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_7_0_X.

PU weighting (70x)

It involves the following packages:

CommonTools/ParticleFlow
RecoParticleFlow/Configuration

@nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks.
@bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@jpavel jpavel mentioned this pull request Jul 3, 2014
@monttj
Copy link
Contributor

monttj commented Jul 3, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2014

@StoyanStoynev
Copy link
Contributor

Waiting for jenkins to finish but this PR is identical to #4131 (for 72X) and #4509 (71X; just reviewed).
I did check that I can run the new customise option with this PR.

@jpavel
Copy link
Contributor Author

jpavel commented Jul 7, 2014

ping? The jenkins somehow did not arrive yet...

@StoyanStoynev
Copy link
Contributor

+1
I'll sign off to avoid blocking the PR, would be good to see the jenkins as a matter of principle.
I tested c41514e on top of CMSSW_7_0_X_2014-07-04-1400. It compiles and the new customise option can be run. The new code is identical to the tested versions for other releases (see above) and does not affect the default running sequences.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@jpavel
Copy link
Contributor Author

jpavel commented Jul 15, 2014

is there anything blocking merging of this PR?

@ktf
Copy link
Contributor

ktf commented Jul 15, 2014

Explicit approval in ORP, since 70X is a closed release. Stoyan gave the ok only 4 days ago so the subsequent ORP is today.

@jpavel
Copy link
Contributor Author

jpavel commented Jul 15, 2014

I see - thanks @ktf for the info!

davidlange6 added a commit that referenced this pull request Jul 15, 2014
@davidlange6 davidlange6 merged commit 95f0029 into cms-sw:CMSSW_7_0_X Jul 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants