Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Update btag from DeepCSV to ParticleNet for BTV DQM #45164

Merged

Conversation

yeonsu108
Copy link
Contributor

This is a backport of #45077. We are backporting this change for the current data taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

A new Pull Request was created by @yeonsu108 for CMSSW_14_0_X.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@syuvivida, @tjavaid, @antoniovagnerini, @cmsbuild, @rvenditti, @nothingface0 can you please review it and eventually sign? Thanks.
@cericeci, @mtosi, @Fedespring, @jhgoh, @missirol, @rociovilar, @HuguesBrun, @trocino this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Jun 7, 2024

backport of #45077

@tjavaid
Copy link

tjavaid commented Jun 7, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-126573/39768/summary.html
COMMIT: 3b164a7
CMSSW: CMSSW_14_0_X_2024-06-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45164/39768/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 27 lines to the logs
  • Reco comparison results: 44 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338712
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338683
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 29819.874 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 4969.979 KiB HLT/BTV
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Jun 8, 2024

please test

  • to fetch bin-by-bin plots, not seen in previous tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-126573/39800/summary.html
COMMIT: 3b164a7
CMSSW: CMSSW_14_0_X_2024-06-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45164/39800/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 17 lines from the logs
  • Reco comparison results: 68 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338712
  • DQMHistoTests: Total failures: 1208
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3337484
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 29819.874 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 4969.979 KiB HLT/BTV
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Jun 11, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a15b87b into cms-sw:CMSSW_14_0_X Jun 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants