[14.0.X] Miscellaneous fixes for TRK POG Data/MC validation tool

[mmusich]

backport of #45173

PR description:

Few miscellaneous fixes for the TRK POG data/MC validation tool:

• a97f012: fix MC KShort analysis sequence
• 69a5846: fix sign of 3D pointing angle variable, make code slightly more readable
• 0f4aa34: fix axis limits for the trackPhiH ME to avoid using dynamic range which causes histogram merging issues

These were spotted by operating the data/MC validation tool on 2024 data.

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #45173 for 2024 data-taking purposes.

Cc: @dbruschi

[mmusich]

type bug-fix

[cmsbuild]

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

• DQM/TrackingMonitorSource (dqm)

@antoniovagnerini, @tjavaid, @rvenditti, @syuvivida, @cmsbuild, @nothingface0 can you please review it and eventually sign? Thanks.
@sroychow, @VourMa, @JanFSchulte, @threus, @arossi83, @mtosi, @jandrea, @fioriNTU, @mmusich, @idebruyn, @VinInn this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Miscellaneous fixes for TRK POG Data/MC validation tool #45173

[cmsbuild]

cms-bot internal usage

[mmusich]

@cmsbuild please test

[cmsbuild]

Pull request #45174 was updated. @antoniovagnerini, @cmsbuild, @rvenditti, @tjavaid, @syuvivida, @nothingface0 can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02b761/39795/summary.html
COMMIT: 0f4aa34
CMSSW: CMSSW_14_0_X_2024-06-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45174/39795/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 67 lines to the logs
• Reco comparison results: 80 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3445220
• DQMHistoTests: Total failures: 2407
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3442793
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 206 log files, 170 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tjavaid]

+1

• spurious differences seen from unstable WFs 12434.7 and 12834.7 (open issue spurious differences in outputs of Run-3 wfs *.7 #39803 )

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

@cms-sw/orp-l2 can this be merged?

[antoniovilela]

+1