Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding various MEs to per-LS scope - backport to 14_0_X #45203

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

rseidita
Copy link
Contributor

PR description:

Backport of #45202

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 12, 2024

A new Pull Request was created by @rseidita for CMSSW_14_0_X.

It involves the following packages:

  • DQMServices/Core (dqm)

@nothingface0, @syuvivida, @antoniovagnerini, @cmsbuild, @rvenditti, @tjavaid can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 12, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Jun 13, 2024

backport of #45202

@tjavaid
Copy link

tjavaid commented Jun 13, 2024

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4f4aa/39861/summary.html
COMMIT: cb2f9b4
CMSSW: CMSSW_14_0_X_2024-06-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45203/39861/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 13-Jun-2024 07:53:52 CEST-----------------------
An exception of category 'LogicError' occurred while
   [0] Processing global end Run run: 1
   [1] Calling method for module METAnalyzer/'pfMetT1DQMAnalyzer'
Exception Message:
MonitorElement MET not backed by any data!
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 13-Jun-2024 07:54:26 CEST-----------------------
An exception of category 'LogicError' occurred while
   [0] Processing global end Run run: 1
   [1] Calling method for module METAnalyzer/'pfMetT1DQMAnalyzer'
Exception Message:
MonitorElement MET not backed by any data!
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 13-Jun-2024 07:55:10 CEST-----------------------
An exception of category 'LogicError' occurred while
   [0] Processing global end Run run: 194533
   [1] Calling method for module METAnalyzer/'pfMetT1DQMAnalyzer'
Exception Message:
MonitorElement MET not backed by any data!
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
  • 138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log
  • 138.5138.5_ExpressCollisions2021/step2_ExpressCollisions2021.log
Expand to see more relval errors ...

@cmsbuild
Copy link
Contributor

Pull request #45203 was updated. @syuvivida, @antoniovagnerini, @rvenditti, @tjavaid, @cmsbuild, @nothingface0 can you please check and sign again.

@tjavaid
Copy link

tjavaid commented Jun 19, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4f4aa/39970/summary.html
COMMIT: 8258862
CMSSW: CMSSW_14_0_X_2024-06-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45203/39970/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342458
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342432
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Jun 20, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6219fd6 into cms-sw:CMSSW_14_0_X Jun 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants