Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Fix RelMon Piecharts using Chart.js #45256

Merged
merged 7 commits into from
Jun 24, 2024

Conversation

AdrianoDee
Copy link
Contributor

Plain backport of #44977.

@AdrianoDee
Copy link
Contributor Author

please test

@AdrianoDee
Copy link
Contributor Author

backport of #44977

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Jun 18, 2024
@AdrianoDee
Copy link
Contributor Author

type bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 18, 2024

A new Pull Request was created by @AdrianoDee for CMSSW_14_0_X.

It involves the following packages:

  • Utilities/RelMon (dqm)

@antoniovagnerini, @syuvivida, @rvenditti, @tjavaid, @nothingface0 can you please review it and eventually sign? Thanks.
@fabiocos, @wddgit this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 18, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34acb9/39953/summary.html
COMMIT: 23e0cc4
CMSSW: CMSSW_14_0_X_2024-06-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45256/39953/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 28 lines to the logs
  • Reco comparison results: 46 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342458
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342435
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Jun 19, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b535764 into cms-sw:CMSSW_14_0_X Jun 24, 2024
10 checks passed
@AdrianoDee AdrianoDee deleted the fix_RelMon_piecharts_140 branch July 9, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants