Change CaloRecHitProducer to produce new HCAL RecHit SoA [14.0.x]

[fwyzard]

PR description:

Quoting @jsamudio:

This PR depends on #45238 and #45199. It implements changes to the CaloRecHitSoAProducer which disables the functionality of converting ECAL rechits, and changes the produced SoA to the new HCAL rechit SoA. This is the first integration step for the use of Alpaka HCAL rechits with the PFRecHitProducer.

PR validation:

Validated with workflow 12434.423 and checking the cluster DQM plots as well.

Technical-only changes, validated running the HLT over 100k events, and obtaining identical results.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45263.

[fwyzard]

type pf

[fwyzard]

backport #45263

[cmsbuild]

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

• RecoParticleFlow/PFRecHitProducer (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@lgray, @mmarionncern, @hatakeyamak, @missirol, @seemasharmafnal this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

• Backported from Change CaloRecHitProducer to produce new HCAL RecHit SoA #45263

[cmsbuild]

cms-bot internal usage

[fwyzard]

assign heterogeneous

[cmsbuild]

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[fwyzard]

+heterogeneous

[fwyzard]

please test with #45239, #45277

[fwyzard]

enable gpu

[cmsbuild]

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0d703/39999/summary.html
COMMIT: bf26a06
CMSSW: CMSSW_14_0_X_2024-06-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45278/39999/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Package Utilities/RelMon built
>> Subsystem Utilities built
Copying tmp/el8_amd64_gcc12/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc12/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc12/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1861: tmp/el8_amd64_gcc12/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a] Error 1
gmake: Target 'all' not remade because of errors.
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2
+ eval scram build outputlog '&&' '(python3' /pool/condor/dir_1450086/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /pool/condor/dir_1450086/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-06-20-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package RecoParticleFlow/PFRecHitProducer


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 96 COMPILER='llvm compile'

>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Creating project symlinks
>> Entering Package RecoParticleFlow/PFRecHitProducer
>> Compile sequence completed for CMSSW CMSSW_14_0_X_2024-06-20-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /pool/condor/dir_1450086/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /pool/condor/dir_1450086/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-06-20-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package RecoParticleFlow/PFRecHitProducer
Entering library rule at src/RecoParticleFlow/PFRecHitProducer/plugins
>> Compiling edm plugin src/RecoParticleFlow/PFRecHitProducer/plugins/LegacyPFRecHitProducer.cc


[fwyzard]

please test with #45277

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #45277

[mandrenguyen]

type hcal

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0d703/40001/summary.html
COMMIT: bf26a06
CMSSW: CMSSW_14_0_X_2024-06-20-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45278/40001/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 25 lines to the logs
• Reco comparison results: 38 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3342458
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3342435
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 35 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39740
• DQMHistoTests: Total failures: 1767
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 37973
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #45277

[antoniovilela]

+1