Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] DQMEventInfo: add the possibility to register the GlobalTag name in a MonitorElement #45282

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 21, 2024

backport of #45286
backport of #45255

PR description:

Quoting from the master PR:

The goal of this PR is to equip DQMEventInfo to add the possibility to register the GlobalTag in a TString MonitorElement. (as already done by DQMProvInfo).
This can be used to make dqmEnvHLT and dqmInfoHLTMon show the last HLT processing GlobalTag. This was requested at CMSHLT-3266.

PR validation:

Run runTheMatrix.py -l 141.042 -t 4 -j 8 and then inspected the resulting DQM file:

Screenshot from 2024-06-18 15-23-02

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #45255 and of #45286 for 2024 data-taking operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 21, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • DQMOffline/Trigger (dqm)
  • DQMServices/Components (dqm)

@syuvivida, @rvenditti, @nothingface0, @tjavaid, @antoniovagnerini, @cmsbuild can you please review it and eventually sign? Thanks.
@barvic, @jhgoh, @HuguesBrun, @missirol, @cericeci, @mtosi, @Fedespring, @rociovilar, @trocino this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 21, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jun 21, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-462c59/40009/summary.html
COMMIT: 5ba803a
CMSSW: CMSSW_14_0_X_2024-06-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45282/40009/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 81 lines to the logs
  • Reco comparison results: 51 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342458
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342432
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 9.235 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 0.048 KiB L1T/L1TriggerVsReco
  • DQMHistoSizes: changed ( 1000.0,... ): 0.037 KiB Tracking/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.036 KiB SiStrip/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.035 KiB L1TEMU/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.034 KiB Muons/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.034 KiB Pixel/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.033 KiB Ecal/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.032 KiB HLT/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.032 KiB L1T/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.032 KiB RPC/EventInfo
  • DQMHistoSizes: changed ( 1000.0 ): ...
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich mmusich force-pushed the mm_dev_HLT-GlobalTag_DQMEventInfo_14_0_X branch from 5ba803a to 1061672 Compare June 24, 2024 08:22
@cmsbuild
Copy link
Contributor

Pull request #45282 was updated. @syuvivida, @antoniovagnerini, @tjavaid, @cmsbuild, @nothingface0, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jun 24, 2024

test parameters:

  • addpkg = DQM/BeamMonitor

@mmusich
Copy link
Contributor Author

mmusich commented Jun 24, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-462c59/40027/summary.html
COMMIT: 1061672
CMSSW: CMSSW_14_0_X_2024-06-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45282/40027/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 27 lines to the logs
  • Reco comparison results: 40 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342458
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342438
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 9.235 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 0.048 KiB L1T/L1TriggerVsReco
  • DQMHistoSizes: changed ( 1000.0,... ): 0.037 KiB Tracking/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.036 KiB SiStrip/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.035 KiB L1TEMU/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.034 KiB Muons/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.034 KiB Pixel/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.033 KiB Ecal/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.032 KiB HLT/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.032 KiB L1T/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.032 KiB RPC/EventInfo
  • DQMHistoSizes: changed ( 1000.0 ): ...
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Jun 26, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a969011 into cms-sw:CMSSW_14_0_X Jun 27, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_HLT-GlobalTag_DQMEventInfo_14_0_X branch June 27, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants