Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix and new configuration for online DQM #4529

Merged
merged 1 commit into from Jul 8, 2014
Merged

Bugfix and new configuration for online DQM #4529

merged 1 commit into from Jul 8, 2014

Conversation

yiiyama
Copy link
Contributor

@yiiyama yiiyama commented Jul 4, 2014

Same content as parallel PR #4527 made for 72X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2014

A new Pull Request was created by @yiiyama (Yutaro Iiyama) for CMSSW_7_1_X.

Bugfix and new configuration for online DQM

It involves the following packages:

DQM/EcalMonitorClient
DQM/EcalMonitorTasks
DQM/Integration

The following packages do not have a category, yet:

DQM/EcalMonitorClient
DQM/EcalMonitorTasks

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano, @ktf can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2014

+1
Tested at: 9d83e21
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4529/1790/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2014

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4529/1790/summary.html

@deguio
Copy link
Contributor

deguio commented Jul 5, 2014

why this PR triggers the flag new-package-pending?
@ktf

thanks,
F.

ktf
ktf reviewed Jul 7, 2014
View reviewed changes
DQM/EcalMonitorClient/python/EcalCalibMonitorClient_cfi.py
@@ -36,7 +36,7 @@
CalibrationSummaryClient = ecalCalibrationSummaryClient
),
commonParameters = ecalCommonParams,
PNMaskFile = cms.untracked.FileInPath("DQM/EcalMonitorClient/data/mask-PN.txt"),
# PNMaskFile = cms.untracked.FileInPath("DQM/EcalMonitorClient/data/mask-PN.txt"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not comment code. Remove it if not needed anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I will take care of this soon. The PR was made in somewhat of a rush during the global run to get online DQM running..

@deguio
Copy link
Contributor

deguio commented Jul 7, 2014

+1

davidlange6 added a commit that referenced this pull request Jul 8, 2014
@davidlange6
Merge pull request #4529 from yiiyama/ecaldqm-online-fix-71X
670ac7a 
Bugfix and new configuration for online DQM
@davidlange6 davidlange6 merged commit 670ac7a into cms-sw:CMSSW_7_1_X Jul 8, 2014
@yiiyama yiiyama deleted the ecaldqm-online-fix-71X branch July 31, 2014 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-pending new-package-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yiiyama @cmsbuild @deguio @ktf @davidlange6