Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X backport] RPCDigis validaiton module update #45305

Merged
merged 12 commits into from
Jul 2, 2024

Conversation

jhgoh
Copy link
Contributor

@jhgoh jhgoh commented Jun 25, 2024

PR description:

This is backport of #45029, update of RPCDigis validation modules.

PR validation:

Passes test with runTheMatrix.py -l 12834.0

If this PR is a backport please specify the original PR and why you need to backport that PR.

This is backport of #45029, already merged to the main branch.
We want to keep the same set of plots during the RPC validation procedure.

@mileva @mrcthiel

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2024

A new Pull Request was created by @jhgoh for CMSSW_14_0_X.

It involves the following packages:

  • Validation/MuonRPCDigis (dqm)

@tjavaid, @antoniovagnerini, @nothingface0, @syuvivida, @cmsbuild, @rvenditti can you please review it and eventually sign? Thanks.
@missirol, @JanFSchulte this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Jun 26, 2024

backport of #45029

@tjavaid
Copy link

tjavaid commented Jun 26, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a08208/40080/summary.html
COMMIT: dd83f5b
CMSSW: CMSSW_14_0_X_2024-06-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45305/40080/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 11 lines from the logs
  • Reco comparison results: 40 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3341703
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3341683
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 21556.199999999993 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 862.248 KiB RPCDigisV/RPCDigis
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Jun 27, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fdf579d into cms-sw:CMSSW_14_0_X Jul 2, 2024
10 checks passed
@jhgoh jhgoh deleted the UpdateRPCDigisV_140X branch July 3, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants