[14.0.X] Improve DetectorStateFilter to check DCS state of selected combinations of Tracker partitions

[mmusich]

backport of #45275

PR description:

This PR concerns an issue regarding the Tracker DCS bits, and the cases in Run 3 where one of these bits went to "False" during data-taking, but Tracker certified the data as good (which led to overriding the content of the DCS-only json) ¹. The most recent case of this was run-380032 (which Tracker marked good, and HLT later marked bad) ².

This concerns HLT because of (at least) two reasons.

• (A) These Tracker-HV DCS bits are used in the online-dqm clients which measure the HLT beamspot: if at least one of the bits is "False", the determination of the online beamspot (which is critical in the HLT reconstruction) may not be updated, so it may be compromised.

• (B) There is a significant number of triggers (~70 triggers, roughly 10% of the physics triggers in the menu) using the tracker-HV DCS bits in the online trigger decision. These are typically triggers for displaced objects whose rates become too large if the pixel or tracker are really "off", so they use the DCS bits as protection. This means that, when one of these bits are "False", these triggers collect no data. If LSs where the tracker-HV DCS bits were "False" are allowed to enter "golden" jsons (which is currently the case), the analyses using these triggers should in principle use a dedicated json to determine the luminosity recorded by these triggers (in this dedicated json, the LSs with TrackerHV=False would be excluded).

A proposed solution to this issue, since as far as I understand the problem is that usually only one DCS partition of the Strip detector (i.e. either one of TIBTID, TOB, TECp, TECm) turns to "DCS = false" despite delivering good data, but the filter we're using both for the HLT beamspot and the HLT paths (DetectorStateFilter )

process.hltStripTrackerHVOn = cms.EDFilter( "DetectorStateFilter",
    DebugOn = cms.untracked.bool( False ),
    DetectorType = cms.untracked.string( "sistrip" ),
    DcsStatusLabel = cms.untracked.InputTag( "" ),
    DCSRecordLabel = cms.untracked.InputTag( "hltOnlineMetaDataDigis" )
)

requires all of partitions to be ON (cf ³ ).
To avoid that situation, one could conceive to change the logic of the filter to require a looser combination (e.g. at least one partition ON, or at least two, or whatever is deemed safer to avoid exploding in rate).
This PR equips DetectorStateFilter to check the DCS state of selected combinations of Tracker partitions in order to leverage this idea. The default behaviour of the filter is NOT changed in this PR. Changing the content of the HLT menu will need to be followed up in a dedicated CMSHLT JIRA ticket, while the changing of the online beamspot clients is in the hands of the BeamSpot team.

PR validation:

Relies on the augmented unit test scram b runtests_test_DetectorStateFilter in which the functionality is tested.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #45275 for 2024 data-taking purposes.

Footnotes

1. https://indico.cern.ch/event/1271493/contributions/5539298/attachments/2698908/4684210/TrkDPGRun368343.pdf ↩

2. https://indico.cern.ch/event/1396796/contributions/5960214/attachments/2858301/5002113/TkDQM_Expert_Tutorial_May24.pdf#page=38 ↩

3. https://github.com/cms-sw/cmssw/blob/9030bf6e5bc33e617ca03ac40e8586ea8b86abc2/DQM/TrackerCommon/plugins/DetectorStateFilter.cc#L117-L118 ↩

[cmsbuild]

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

• DQM/TrackerCommon (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@arossi83, @fioriNTU, @idebruyn, @jandrea, @sroychow, @threus this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Improve DetectorStateFilter to check DCS state of selected combinations of Tracker partitions #45275

[cmsbuild]

cms-bot internal usage

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b350be/40119/summary.html
COMMIT: 772ffbe
CMSSW: CMSSW_14_0_X_2024-06-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45322/40119/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 98 lines from the logs
• Reco comparison results: 125 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3342528
• DQMHistoTests: Total failures: 2568
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3339940
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

@cms-sw/dqm-l2 can I help the review in any way?

[tjavaid]

+1

• spurious differences seen from unstable WF 12834.7 (open issue spurious differences in outputs of Run-3 wfs *.7 #39803)
• PR [14.0.X] Fix lostDict: Add HcalRecHitSoA for HcalRecHit package #45301 should fix the missing HcalRecHitSoA dict.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1