Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Rename MUODPG nano flatTable producers #45334

Merged

Conversation

battibass
Copy link

PR description:

The PR addresses a (second) issue observed when attempting the central production of the MUODPG nano custom flavour:

Configuration/DataProcessing/test/RunMerge.py retains, out of collections from NANOEDMAODoutput, only the ones whose producer's name is of the form *Table.
The MUOPDG nano flavour sequence was adapted accordingly.

It is a backport of #45321

A small difference in the event content, too small to affect event-size significantly, is expected.

PR validation:

Tested using dedicated runTheMatrix.py workflows.
Also tested running the actual PdmV production workflow, followed by Configuration/DataProcessing/test/RunMerge.py.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @battibass for CMSSW_14_0_X.

It involves the following packages:

  • DPGAnalysis/MuonTools (xpog)

@cmsbuild, @ftorrresd, @hqucms, @vlimant can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2024

cms-bot internal usage

@battibass
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a0270/40135/summary.html
COMMIT: 3369b0c
CMSSW: CMSSW_14_0_X_2024-06-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45334/40135/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@vlimant
Copy link
Contributor

vlimant commented Jun 28, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Jun 28, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a0270/40150/summary.html
COMMIT: 3369b0c
CMSSW: CMSSW_14_0_X_2024-06-28-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45334/40150/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 51 log files, 31 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.91 3.93 -0.7% 2.231 2.137
2500.001 2.897 2.897 0.000 ( +0.0% ) 3.48 3.53 -1.4% 2.561 2.527
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.65 3.66 -0.2% 2.556 2.523
2500.01 1.446 1.446 0.000 ( +0.0% ) 6.81 6.92 -1.6% 2.255 2.243
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.67 3.65 +0.5% 2.463 2.374
2500.012 1.761 1.761 0.000 ( +0.0% ) 5.34 5.37 -0.6% 2.350 2.305
2500.1 2.354 2.354 0.000 ( +0.0% ) 5.12 5.17 -0.8% 2.089 1.962
2500.2 2.459 2.459 0.000 ( +0.0% ) 5.82 5.95 -2.2% 1.999 1.871
2500.21 1.286 1.286 0.000 ( +0.0% ) 4.14 4.17 -0.8% 2.302 2.157
2500.211 1.668 1.668 0.000 ( +0.0% ) 3.79 3.85 -1.5% 2.370 2.182
2500.3 2.229 2.229 0.000 ( +0.0% ) 11.56 12.30 -6.0% 1.980 1.873
2500.301 2.833 2.833 0.000 ( +0.0% ) 10.28 10.98 -6.4% 1.964 1.826
2500.31 1.348 1.348 0.000 ( +0.0% ) 18.77 19.38 -3.2% 2.379 2.241
2500.311 1.757 1.757 0.000 ( +0.0% ) 14.63 14.99 -2.4% 2.448 2.284
2500.312 7.164 7.164 0.000 ( +0.0% ) 1.50 1.54 -2.7% 1.699 1.694
2500.313 1.568 1.568 0.000 ( +0.0% ) 9.23 9.20 +0.3% 1.046 1.048
2500.314 1.236 1.236 0.000 ( +0.0% ) 13.94 14.61 -4.6% 2.211 2.196
2500.315 1.874 1.874 0.000 ( +0.0% ) 14.69 15.46 -5.0% 2.341 2.344
2500.316 3.342 3.342 0.000 ( +0.0% ) 2.05 2.11 -2.9% 2.308 2.146
2500.317 1.811 1.811 0.000 ( +0.0% ) 13.83 14.67 -5.7% 2.159 2.143
2500.318 4.136 4.136 0.000 ( +0.0% ) 5.50 5.82 -5.5% 2.173 2.134
2500.319 3.364 3.364 0.000 ( +0.0% ) 1.82 1.87 -2.3% 2.021 2.148
2500.4 2.374 2.374 0.000 ( +0.0% ) 11.20 11.42 -2.0% 1.850 1.815
2500.401 1.885 1.885 0.000 ( +0.0% ) 10.11 10.70 -5.5% 1.738 1.678
2500.402 2.950 2.950 0.000 ( +0.0% ) 9.39 10.42 -9.9% 1.703 1.700
2500.403 5.474 5.474 0.000 ( +0.0% ) 1.43 1.48 -2.9% 1.953 1.856
2500.404 2.860 2.860 0.000 ( +0.0% ) 10.01 10.81 -7.4% 1.864 1.769
2500.405 8.700 8.700 0.000 ( +0.0% ) 3.45 3.68 -6.4% 1.754 1.770
2500.406 5.491 5.491 0.000 ( +0.0% ) 1.34 1.37 -2.2% 1.992 1.901
2500.5 5.194 5.194 0.000 ( +0.0% ) 15.74 16.34 -3.7% 1.543 1.559
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.80 9.98 -1.8% 1.604 1.615

@vlimant
Copy link
Contributor

vlimant commented Jul 1, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 20aa819 into cms-sw:CMSSW_14_0_X Jul 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants