Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to include HTMHF triggers in GT emulator and propagation to HLTL1Seed #45356

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

elfontan
Copy link
Contributor

@elfontan elfontan commented Jul 1, 2024

PR description:

Backport of #45295 needed for the deployment of the next L1+HLT menus.

This PR includes updates for the HTMHF triggers in GT emulator, which are included starting from v1_3_0 of the L1 menu (end of 2024 pp data-taking), as detailed in the following:

  • Inclusion of HTMHF object type in ESum in the GT data formats
  • Updates of the TriggerMenuParser to properly parse the new condition from the xml menu (according to new utm libraries utm_0.13.0: see code and documentation).
  • Propagation of the HTMHF trigger implementation to EnergySum condition (and correlations)
  • Propagation of the type definition changes to DataFormats/HLTReco and HLTL1TSeed module

Note that the updated GtRecordDump includes also the changes included (and not backported at that time) in
#43921 to properly accomodate the muon shower information in the muon word when producing test vectors for firmware-emulator cross-validation.

PR validation:

The PR has been prepared starting from CMSSW_14_0_X_2024-06-30-2300:

cmsrel CMSSW_14_0_X_2024-06-30-2300
cd CMSSW_14_0_X_2024-06-30-2300/src
cmsenv
git cms-init
git cms-addpkg L1Trigger/L1TGlobal
git cms-addpkg DataFormats/L1TGlobal
git cms-addpkg DataFormats/HLTReco
git cms-addpkg HLTrigger/HLTfilters
scram b && scram b code-checks && scram b code-format && scram b

NOTE: attempt to produce test vectors based on the latest L1Menu_Collisions2024_v1_3_0:

Cannot load library: GTADModel_v4.so: cannot open shared object file: No such file or directory
----- Begin Fatal Exception 01-Jul-2024 20:48:48 CEST-----------------------
An exception of category 'ModelError' occurred while
   [0] Processing  Event run: 381065 lumi: 524 event: 1049642024 stream: 0
   [1] Running path 'p1'
   [2] Calling method for module L1TGlobalProducer/'simGtStage2Digis'
Exception Message:
 ERROR: failed to load AXOL1TL model version "GTADModel_v4" that was specified in menu. Model version not found in cms-hls4ml externals.
----- End Fatal Exception -------------------------------------------------

It looks related to the missing update of cms-dist with PR cms-sw/cmsdist#9272 (backport of cms-sw/cmsdist#9271). Details in https://its.cern.ch/jira/browse/CMSLITDPG-1296.

[cc: @aloeliger @epalencia @slaurila @eyigitba @caruta @thesps for L1 and AXO]

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

A new Pull Request was created by @elfontan for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/HLTReco (hlt)
  • DataFormats/L1TGlobal (l1)
  • HLTrigger/HLTfilters (hlt)
  • L1Trigger/L1TGlobal (l1)

@Martin-Grunewald, @aloeliger, @cmsbuild, @epalencia, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @rovere, @silviodonato this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Jul 1, 2024

@cmsbuild, please test

@aloeliger
Copy link
Contributor

Backport of #45295

@missirol
Copy link
Contributor

missirol commented Jul 1, 2024

Backport of #45295

Just for my understanding, is this PR also backporting #43921 ? @elfontan

@elfontan
Copy link
Contributor Author

elfontan commented Jul 1, 2024

Backport of #45295

Just for my understanding, is this PR also backporting #43921 ? @elfontan

Hi @missirol, yes that backport was never done (and it caused me problems in the first PR preparation) so I considered that it was better to have things aligned again.

@missirol
Copy link
Contributor

missirol commented Jul 1, 2024

yes that backport was never done (and it caused me problems in the first PR preparation) so I considered that it was better to have things aligned again.

I think it would be good to write this in the description of this PR (and possibly update the title accordingly).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99670a/40175/summary.html
COMMIT: 902a2b0
CMSSW: CMSSW_14_0_X_2024-07-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45356/40175/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Jul 2, 2024

backport of #43921

@mmusich
Copy link
Contributor

mmusich commented Jul 2, 2024

+hlt

@mmusich
Copy link
Contributor

mmusich commented Jul 2, 2024

urgent

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c4c36bf into cms-sw:CMSSW_14_0_X Jul 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants